linux-kernel - Re: [PATCH net] net: phy: micrel: always set shared->phydev for LAN8814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251022071918.2uytekajbs5g23dw@DEN-DL-M31836.microchip.com>
Date: Wed, 22 Oct 2025 09:19:18 +0200
From: Horatiu Vultur <horatiu.vultur@...rochip.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Robert Marko <robert.marko@...tura.hr>, <daniel.machon@...rochip.com>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<vadim.fedorenko@...ux.dev>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <luka.perkov@...tura.hr>
Subject: Re: [PATCH net] net: phy: micrel: always set shared->phydev for
 LAN8814

The 10/21/2025 15:32, Andrew Lunn wrote:

Hi,

> 
> On Tue, Oct 21, 2025 at 03:20:26PM +0200, Robert Marko wrote:
> > Currently, during the LAN8814 PTP probe shared->phydev is only set if PTP
> > clock gets actually set, otherwise the function will return before setting
> > it.
> >
> > This is an issue as shared->phydev is unconditionally being used when IRQ
> > is being handled, especially in lan8814_gpio_process_cap and since it was
> > not set it will cause a NULL pointer exception and crash the kernel.
> >
> > So, simply always set shared->phydev to avoid the NULL pointer exception.
> >
> > Fixes: b3f1a08fcf0d ("net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814")
> > Signed-off-by: Robert Marko <robert.marko@...tura.hr>
> 
> Please could you look at how this patch and
> 
> [PATCH net-next v2] net: phy: micrel: Add support for non PTP SKUs for lan8814
> 
> work together. It might be this patch is not required because of
> changes in that patch?

I managed to reproduce this issue also with the patch:

[PATCH net-next v2] net: phy: micrel: Add support for non PTP SKUs for lan8814

The way I reproduced the issue is by disabling the config PTP_1588_CLOCK
and then just set the port up to get an interrupt.
Then I try to apply this patch and then the issue was fixed.

Tested-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

> 
> Thanks
>         Andrew

-- 
/Horatiu