linux-kernel - Re: [PATCH net] net: phy: micrel: always set shared->phydev for LAN8814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023071259.77076fd4@kernel.org>
Date: Thu, 23 Oct 2025 07:12:59 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Robert Marko <robert.marko@...tura.hr>
Cc: daniel.machon@...rochip.com, andrew@...n.ch, hkallweit1@...il.com,
 linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, vadim.fedorenko@...ux.dev, horatiu.vultur@...rochip.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 luka.perkov@...tura.hr
Subject: Re: [PATCH net] net: phy: micrel: always set shared->phydev for
 LAN8814

On Tue, 21 Oct 2025 15:20:26 +0200 Robert Marko wrote:
> Currently, during the LAN8814 PTP probe shared->phydev is only set if PTP
> clock gets actually set, otherwise the function will return before setting
> it.
> 
> This is an issue as shared->phydev is unconditionally being used when IRQ
> is being handled, especially in lan8814_gpio_process_cap and since it was
> not set it will cause a NULL pointer exception and crash the kernel.
> 
> So, simply always set shared->phydev to avoid the NULL pointer exception.
> 
> Fixes: b3f1a08fcf0d ("net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814")
> Signed-off-by: Robert Marko <robert.marko@...tura.hr>

Hopefully I'm not misunderstanding the situation, but since we're
considering taking the other patchset via net-next I'll apply
already this to prevent crashes in net..