linux-kernel - Re: [PATCH v4 2/2] perf tools annotate: Align the symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aac9daf9-126b-4c55-8d29-8e456b305cc8@linaro.org>
Date: Tue, 21 Oct 2025 14:56:23 +0100
From: James Clark <james.clark@...aro.org>
To: Tianyou Li <tianyou.li@...el.com>, Namhyung Kim <namhyung@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 Kan Liang <kan.liang@...ux.intel.com>, Ravi Bangoria
 <ravi.bangoria@....com>, wangyang.guo@...el.com, pan.deng@...el.com,
 zhiguo.zhou@...el.com, jiebin.sun@...el.com, thomas.falcon@...el.com,
 dapeng1.mi@...el.com, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] perf tools annotate: Align the symbol_annotate
 return code



On 20/10/2025 8:30 am, Tianyou Li wrote:
> Return error code from the symbol_annotate previously checks the
> evsel__get_arch from '<0', now to '!=0'.
> 
> Suggested-by: James Clark <james.clark@...aro.org>
> Acked-by: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Tianyou Li <tianyou.li@...el.com>
> ---
>   tools/perf/util/annotate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 39d6594850f1..859e802a1e5e 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -1021,7 +1021,7 @@ int symbol__annotate(struct map_symbol *ms, struct evsel *evsel,
>   	int err, nr;
>   
>   	err = evsel__get_arch(evsel, &arch);
> -	if (err < 0)
> +	if (err)
>   		return err;
>   
>   	if (parch)

Reviewed-by: James Clark <james.clark@...aro.org>