linux-kernel - Re: [PATCH v4 1/2] perf tools annotate: fix a crash when annotate the same symbol with 's' and 'T'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <176109355778.1850903.1376466916179653638.b4-ty@kernel.org>
Date: Tue, 21 Oct 2025 17:39:17 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: James Clark <james.clark@...aro.org>, Tianyou Li <tianyou.li@...el.com>
Cc: Peter Zijlstra <peterz@...radead.org>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Mark Rutland <mark.rutland@....com>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, 
 Adrian Hunter <adrian.hunter@...el.com>, 
 Kan Liang <kan.liang@...ux.intel.com>, 
 Ravi Bangoria <ravi.bangoria@....com>, wangyang.guo@...el.com, 
 pan.deng@...el.com, zhiguo.zhou@...el.com, jiebin.sun@...el.com, 
 thomas.falcon@...el.com, dapeng1.mi@...el.com, 
 linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] perf tools annotate: fix a crash when annotate
 the same symbol with 's' and 'T'

On Mon, 20 Oct 2025 15:30:04 +0800, Tianyou Li wrote:
> When perf report with annotation for a symbol, press 's' and 'T', then exit
> the annotate browser. Once annotate the same symbol, the annotate browser
> will crash.
> 
> The browser.arch was required to be correctly updated when data type
> feature was enabled by 'T'. Usually it was initialized by symbol__annotate2
> function. If a symbol has already been correctly annotated at the first
> time, it should not call the symbol__annotate2 function again, thus the
> browser.arch will not get initialized. Then at the second time to show the
> annotate browser, the data type needs to be displayed but the browser.arch
> is empty.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung