linux-kernel - Re: [PATCH v4 09/16] blktrace: add definitions for struct blk_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d703eb46-55a1-4e0a-9658-b1fce9111d04@kernel.org>
Date: Wed, 22 Oct 2025 05:51:12 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Johannes Thumshirn <johannes.thumshirn@....com>, axboe@...nel.dk
Cc: chaitanyak@...dia.com, hare@...e.de, hch@....de, john.g.garry@...cle.com,
 linux-block@...r.kernel.org, linux-btrace@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 martin.petersen@...cle.com, mathieu.desnoyers@...icios.com,
 mhiramat@...nel.org, naohiro.aota@....com, rostedt@...dmis.org,
 shinichiro.kawasaki@....com
Subject: Re: [PATCH v4 09/16] blktrace: add definitions for struct
 blk_io_trace2

On 10/20/25 22:41, Johannes Thumshirn wrote:
> Add definitions for the extended version of the blktrace protocol using a
> wider action type to be able to record new actions in the kernel.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>

One nit below.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>


> +struct blk_io_trace2 {
> +	__u32 magic;		/* MAGIC << 8 | BLK_IO_TRACE2_VERSION */
> +	__u32 sequence;		/* event number */
> +	__u64 time;		/* in nanoseconds */
> +	__u64 sector;		/* disk offset */
> +	__u32 bytes;		/* transfer length */
> +	__u32 pid;		/* who did it */
> +	__u64 action;		/* what happened */
> +	__u32 device;		/* device number */
> +	__u32 cpu;		/* on what cpu did it happen */
> +	__u16 error;		/* completion error */
> +	__u16 pdu_len;		/* length of data after this trace */
> +	__u8 pad[12];
> +	/* cgroup id will be stored here if exists */

s/if exists/if it exists

-- 
Damien Le Moal
Western Digital Research