linux-kernel - Re: [PATCH v4 10/16] blktrace: differentiate between blk_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a366bbf-49e9-4b53-bbd4-4a28454f8f90@kernel.org>
Date: Wed, 22 Oct 2025 05:54:13 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Johannes Thumshirn <johannes.thumshirn@....com>, axboe@...nel.dk
Cc: chaitanyak@...dia.com, hare@...e.de, hch@....de, john.g.garry@...cle.com,
 linux-block@...r.kernel.org, linux-btrace@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 martin.petersen@...cle.com, mathieu.desnoyers@...icios.com,
 mhiramat@...nel.org, naohiro.aota@....com, rostedt@...dmis.org,
 shinichiro.kawasaki@....com
Subject: Re: [PATCH v4 10/16] blktrace: differentiate between blk_io_trace
 versions

On 10/20/25 22:41, Johannes Thumshirn wrote:
> Differentiate between blk_io_trace and blk_io_trace2 when relaying to
> user-space depending on which version has been requested by the blktrace
> utility.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>

One nit below.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

> @@ -146,8 +202,8 @@ static void trace_note(struct blk_trace *bt, pid_t pid, u64 action,
>  	if (!bt->rchan)
>  		return;
>  
> -	relay_blktrace_event(bt, 0, pid, cpu, 0, 0, action, 0, cgid,
> -			     cgid_len, (void *)data, len);
> +	relay_blktrace_event(bt, 0, pid, cpu, 0, 0, action, 0, cgid, cgid_len,
> +			     (void *)data, len);

You are not changing anything here, so this is just churn...
Not a huge problem, but not needed.

>  }
>  
>  /*


-- 
Damien Le Moal
Western Digital Research