linux-kernel - Re: [PATCH v4 4/4] watchdog: sony-cronos-smc: Add watchdog driver for Sony Cronos SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89f4378f-c876-4c0e-8484-1a6144a6edfe@linaro.org>
Date: Tue, 21 Oct 2025 12:41:19 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Timothy Pearson <tpearson@...torengineering.com>,
 devicetree <devicetree@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>, Rob Herring
 <robh+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Lee Jones <lee@...nel.org>, Georgy Yakovlev <Georgy.Yakovlev@...y.com>
Subject: Re: [PATCH v4 4/4] watchdog: sony-cronos-smc: Add watchdog driver for
 Sony Cronos SMC

On 20/10/2025 20:15, Timothy Pearson wrote:
> The Sony Cronos Platform Controller is a multi-purpose platform controller with
> an integrated watchdog.  Add the watchdog driver for the Cronos SMC.


Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Signed-off-by: Timothy Pearson <tpearson@...torengineering.com>
> ---

...


> +
> +static const struct of_device_id sony_cronos_compatible_id_table[] = {
> +	{
> +		.compatible = "sony,cronos-watchdog",

Undocumented compatible, drop entire table.

> +	},
> +	{},
> +};
> +



...

> +
> +static SIMPLE_DEV_PM_OPS(sony_cronos_wdt_pm_ops, sony_cronos_wdt_suspend, sony_cronos_wdt_resume);
> +
> +static struct platform_driver sony_cronos_wdt_driver = {
> +	.probe = sony_cronos_wdt_probe,
> +	.driver = {
> +		.name = "sony-cronos-watchdog",
> +		.pm = &sony_cronos_wdt_pm_ops,
> +		.of_match_table = sony_cronos_compatible_id_table,

Either this or platform module alias, not both. Since you do not have
compatibles, then drop this and keep the alias.

> +	},
> +};
> +module_platform_driver(sony_cronos_wdt_driver);
> +
> +MODULE_AUTHOR("Raptor Engineering, LLC <tpearson@...torengineering.com>");
> +MODULE_DESCRIPTION("WDT device driver for Sony Cronos SMCs");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:sony-cronos-watchdog");

Best regards,
Krzysztof