linux-kernel - Re: [PATCH v4 1/4] dt-bindings: mfd: Add sony,cronos-smc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7630eb1-2686-491e-81ed-fb43fff2dd31@linaro.org>
Date: Tue, 21 Oct 2025 12:44:20 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Timothy Pearson <tpearson@...torengineering.com>,
 devicetree <devicetree@...r.kernel.org>,
 linux-kernel <linux-kernel@...r.kernel.org>, Rob Herring
 <robh+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Lee Jones <lee@...nel.org>, Georgy Yakovlev <Georgy.Yakovlev@...y.com>
Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: Add sony,cronos-smc

On 20/10/2025 20:12, Timothy Pearson wrote:
> +
> +properties:
> +  compatible:
> +    const: sony,cronos-smc
> +
> +  reg:
> +    maxItems: 1
> +
> +  timeout-sec: true

Drop, not needed.

> +
> +  leds:
> +    type: object
> +    additionalProperties: false
> +    description: |
> +      The Cronos LED controller is a subfunction of the Cronos platform
> +      controller, which is a multi-function device.
> +
> +      Each led is represented as a child node of sony,cronos-led. Fifteen RGB
> +      LEDs are supported by the platform.

Fifteen?

> +
> +    properties:
> +      compatible:
> +        const: sony,cronos-led
> +
> +      reg:
> +        maxItems: 1
> +
> +      "#address-cells":
> +        const: 1
> +
> +      "#size-cells":
> +        const: 0
> +
> +    patternProperties:
> +      "^multi-led@[0-15]$":

Unit addresses are hex.

> +        type: object
> +        $ref: leds-class-multicolor.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          reg:
> +            description:
> +              LED channel number (0..15)

but here is sixteen...

> +            minimum: 0
> +            maximum: 15
> +
> +        required:
> +          - reg
> +
> +    required:
> +      - compatible
> +      - "#address-cells"
> +      - "#size-cells"
> +
> +required:
> +  - compatible
> +  - reg
> +
> +allOf:
> +  - $ref: /schemas/watchdog/watchdog.yaml

Come with sensible, generic node name and update the schema like I did.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +
> +    #include <dt-bindings/leds/common.h>
> +
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      smc@3f {
> +        compatible = "sony,cronos-smc";
> +        reg = <0x3f>;
> +
> +        timeout-sec = <20>;
> +
> +        leds {
> +            compatible = "sony,cronos-led";

Keep consistent indentation. Use 4 spaces for example indentation.

> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            multi-led@0 {
> +                /*
> +                 * No subnodes are needed, this controller only supports RGB
> +                 * LEDs.
> +                 */
> +                reg = <0>;
> +                color = <LED_COLOR_ID_MULTI>;
> +                function = LED_FUNCTION_STATUS;
> +            };
> +        };
> +      };
> +    };


Best regards,
Krzysztof