linux-kernel - Re: [PATCH v5 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: add spi bus properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPjnKs7D7b6hbloo@lonswws03.ad.cirrus.com>
Date: Wed, 22 Oct 2025 15:16:10 +0100
From: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
        David Rhodes <david.rhodes@...rus.com>,
        Richard Fitzgerald <rf@...nsource.cirrus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
        linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v5 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: add
 spi bus properties

On Wed, Oct 22, 2025 at 03:50:09PM +0200, Krzysztof Kozlowski wrote:
> On 22/10/2025 15:42, Krzysztof Kozlowski wrote:
> > On 22/10/2025 15:38, Vitaly Rodionov wrote:
> >> This patch adds property for cs530x SPI control bus
> >> with max frequency 24MHz.
> > 
> > Why?
> > 
> > You described what you did, we see that from the diff. Explain why you
> > are doing this, e.g. hardware is like that? Old hardware? New hardware?
> > Both? If only new, then why this is a separate patch?
> > 
> > Also, since I expect new version:
> > Please do not use "This commit/patch/change", but imperative mood. See
> > longer explanation here:
> > https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94
> >
> 
> And after looking at next patch I understand why - you add SPI which was
> not there, so this patch is not correct alone anyway. You need a ref to
> spi-peripheral-props (see any other SPI device). My previous questions
> still stay valid though - how this relates to existing devices and to
> earlier patch.
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Thanks for pointing that out. You’re correct — the SPI part is added in the next patch,
so this one isn’t fully correct on its own. I’ll fix it by adding a reference to spi-peripheral-props
and will address your previous questions about its relation to existing devices and the earlier patch.

Thanks,
Vitaly