lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202510222115.WBPLEBsN-lkp@intel.com>
Date: Wed, 22 Oct 2025 22:09:20 +0800
From: kernel test robot <lkp@...el.com>
To: Biancaa Ramesh <biancaa2210329@....edu.in>, linux-media@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, awalls@...metrocast.net,
	mchehab@...nel.org, linux-kernel@...r.kernel.org,
	Biancaa Ramesh <biancaa2210329@....edu.in>
Subject: Re: [PATCH] pcmcia/parport_cs: Refactor probe function and improve
 error logging

Hi Biancaa,

kernel test robot noticed the following build errors:

[auto build test ERROR on sailus-media-tree/master]
[also build test ERROR on linus/master v6.18-rc2 next-20251022]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Biancaa-Ramesh/pcmcia-parport_cs-Refactor-probe-function-and-improve-error-logging/20251022-030324
base:   git://linuxtv.org/sailus/media_tree.git master
patch link:    https://lore.kernel.org/r/20251021190021.173748-1-biancaa2210329%40ssn.edu.in
patch subject: [PATCH] pcmcia/parport_cs: Refactor probe function and improve error logging
config: x86_64-buildonly-randconfig-006-20251022 (https://download.01.org/0day-ci/archive/20251022/202510222115.WBPLEBsN-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251022/202510222115.WBPLEBsN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510222115.WBPLEBsN-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/parport/parport_cs.c: In function 'parport_config':
>> drivers/parport/parport_cs.c:164:9: error: label 'failed' used but not defined
     164 |         goto failed;
         |         ^~~~
>> drivers/parport/parport_cs.c:137:21: warning: unused variable 'info' [-Wunused-variable]
     137 |     parport_info_t *info = link->priv;
         |                     ^~~~
>> drivers/parport/parport_cs.c:167:5: warning: no return statement in function returning non-void [-Wreturn-type]
     167 |     }
         |     ^
   drivers/parport/parport_cs.c: At top level:
>> drivers/parport/parport_cs.c:169:6: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
     169 |     p->modes |= PARPORT_MODE_PCSPP;
         |      ^~
>> drivers/parport/parport_cs.c:170:5: error: expected identifier or '(' before 'if'
     170 |     if (epp_mode)
         |     ^~
   drivers/parport/parport_cs.c:172:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
     172 |     info->ndev = 1;
         |         ^~
   drivers/parport/parport_cs.c:173:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
     173 |     info->port = p;
         |         ^~
>> drivers/parport/parport_cs.c:175:5: error: expected identifier or '(' before 'return'
     175 |     return 0;
         |     ^~~~~~
>> drivers/parport/parport_cs.c:177:7: error: expected '=', ',', ';', 'asm' or '__attribute__' before ':' token
     177 | failed:
         |       ^
>> drivers/parport/parport_cs.c:179:19: error: expected ')' before '->' token
     179 |         kfree(link->priv);
         |                   ^~
         |                   )
   drivers/parport/parport_cs.c:180:9: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
     180 |     link->priv = NULL;
         |         ^~
   drivers/parport/parport_cs.c:181:9: error: expected identifier or '(' before 'return'
     181 |         return -ENODEV;
         |         ^~~~~~
>> drivers/parport/parport_cs.c:182:1: error: expected identifier or '(' before '}' token
     182 | } /* parport_config */
         | ^

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for OF_GPIO
   Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
   Selected by [y]:
   - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && (ARC_PLAT_TB10X || COMPILE_TEST [=y])
   WARNING: unmet direct dependencies detected for GPIO_SYSCON
   Depends on [n]: GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF [=n]
   Selected by [y]:
   - GPIO_SAMA5D2_PIOBU [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y] && OF_GPIO [=y] && (ARCH_AT91 || COMPILE_TEST [=y])
   WARNING: unmet direct dependencies detected for I2C_K1
   Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && OF [=n]
   Selected by [y]:
   - MFD_SPACEMIT_P1 [=y] && HAS_IOMEM [=y] && (ARCH_SPACEMIT || COMPILE_TEST [=y]) && I2C [=y]


vim +/failed +164 drivers/parport/parport_cs.c

84e2d34004dcd0c Dominik Brodowski 2008-07-29  134  
15b99ac1729503d Dominik Brodowski 2006-03-31  135  static int parport_config(struct pcmcia_device *link)
^1da177e4c3f415 Linus Torvalds    2005-04-16  136  {
^1da177e4c3f415 Linus Torvalds    2005-04-16 @137      parport_info_t *info = link->priv;
^1da177e4c3f415 Linus Torvalds    2005-04-16  138      struct parport *p;
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  139      int ret;
^1da177e4c3f415 Linus Torvalds    2005-04-16  140  
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  141      dev_dbg(&link->dev, "parport_config\n");
^1da177e4c3f415 Linus Torvalds    2005-04-16  142  
00990e7ce0b0e59 Dominik Brodowski 2010-07-30  143      if (epp_mode)
00990e7ce0b0e59 Dominik Brodowski 2010-07-30  144  	    link->config_index |= FORCE_EPP_MODE;
00990e7ce0b0e59 Dominik Brodowski 2010-07-30  145  
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  146      ret = pcmcia_loop_config(link, parport_config_check, NULL);
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  147      if (ret)
84e2d34004dcd0c Dominik Brodowski 2008-07-29  148  	    goto failed;
^1da177e4c3f415 Linus Torvalds    2005-04-16  149  
eb14120f743d297 Dominik Brodowski 2010-03-07  150      if (!link->irq)
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  151  	    goto failed;
1ac71e5a35eebee Dominik Brodowski 2010-07-29  152      ret = pcmcia_enable_device(link);
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  153      if (ret)
9b44de2015ff4a2 Dominik Brodowski 2009-10-24  154  	    goto failed;
^1da177e4c3f415 Linus Torvalds    2005-04-16  155  
9a017a910346afd Dominik Brodowski 2010-07-24  156      p = parport_pc_probe_port(link->resource[0]->start,
9a017a910346afd Dominik Brodowski 2010-07-24  157  			      link->resource[1]->start,
eb14120f743d297 Dominik Brodowski 2010-03-07  158  			      link->irq, PARPORT_DMA_NONE,
51dcdfec6a274af Alan Cox          2009-04-07  159  			      &link->dev, IRQF_SHARED);
fac3d7d7b11c825 Biancaa Ramesh    2025-10-22  160      if (!p) {
fac3d7d7b11c825 Biancaa Ramesh    2025-10-22  161          dev_err(&link->dev,
fac3d7d7b11c825 Biancaa Ramesh    2025-10-22  162              "parport_pc_probe_port() failed at 0x%03x, irq %u\n",
decf26f6ec25dac Joe Perches       2020-04-03  163              (unsigned int)link->resource[0]->start, link->irq);
^1da177e4c3f415 Linus Torvalds    2005-04-16 @164          goto failed;
^1da177e4c3f415 Linus Torvalds    2005-04-16  165      }   
^1da177e4c3f415 Linus Torvalds    2005-04-16  166  
fac3d7d7b11c825 Biancaa Ramesh    2025-10-22 @167      }
fac3d7d7b11c825 Biancaa Ramesh    2025-10-22  168  
^1da177e4c3f415 Linus Torvalds    2005-04-16 @169      p->modes |= PARPORT_MODE_PCSPP;
^1da177e4c3f415 Linus Torvalds    2005-04-16 @170      if (epp_mode)
^1da177e4c3f415 Linus Torvalds    2005-04-16  171  	p->modes |= PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP;
^1da177e4c3f415 Linus Torvalds    2005-04-16  172      info->ndev = 1;
^1da177e4c3f415 Linus Torvalds    2005-04-16  173      info->port = p;
^1da177e4c3f415 Linus Torvalds    2005-04-16  174  
15b99ac1729503d Dominik Brodowski 2006-03-31 @175      return 0;
^1da177e4c3f415 Linus Torvalds    2005-04-16  176  
^1da177e4c3f415 Linus Torvalds    2005-04-16 @177  failed:
^1da177e4c3f415 Linus Torvalds    2005-04-16  178  	parport_cs_release(link);
21c75ad65f8e521 YueHaibing        2019-03-21 @179  	kfree(link->priv);
fac3d7d7b11c825 Biancaa Ramesh    2025-10-22  180      link->priv = NULL;
15b99ac1729503d Dominik Brodowski 2006-03-31  181  	return -ENODEV;
^1da177e4c3f415 Linus Torvalds    2005-04-16 @182  } /* parport_config */
^1da177e4c3f415 Linus Torvalds    2005-04-16  183  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ