linux-kernel - Re: [PATCH] parport_cs: Refactor probe function and improve error logging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2bbe001-80dc-43ab-9cc9-3bf497731183@web.de>
Date: Wed, 22 Oct 2025 18:30:40 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Biancaa Ramesh <biancaa2210329@....edu.in>,
 Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
 Andy Walls <awalls@...metrocast.net>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] parport_cs: Refactor probe function and improve error
 logging

> - Replaced pr_notice with dev_err for proper kernel error logging.
> - Added explicit cleanup of link->priv on failure in probe and config.
> - Improved comments and readability in parport_probe() and parport_config().
> - Ensured allocation checks are consistent (kzalloc returns checked).
> - Minor refactoring for clarity and maintainability.

Thanks for your try to adjust two function implementations.
https://elixir.bootlin.com/linux/v6.18-rc2/source/drivers/parport/parport_cs.c#L83-L162

I see possibilities to improve such a change description another bit.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc2#n81

Please recheck the indentation approach accordingly.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc2#n18

…
> -- 
> ::DISCLAIMER::
…
> The 
> contents of this e-mail and any attachment(s) are confidential and
…

Please avoid such unwanted information for communication by the means of public mailing lists.
https://subspace.kernel.org/etiquette.html#do-not-include-confidentiality-disclaimers

Regards,
Markus