linux-kernel - Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers automatic module loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d38779a7-a1af-49e4-b429-5ebd791e2168@sirena.org.uk>
Date: Wed, 22 Oct 2025 15:56:22 +0100
From: Mark Brown <broonie@...nel.org>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>
Cc: Javier Martinez Canillas <javierm@...hat.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Herve Codina <herve.codina@...tlin.com>,
	David Rhodes <david.rhodes@...rus.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Nikita Shubin <nikita.shubin@...uefel.me>,
	Axel Lin <axel.lin@...ics.com>,
	Brian Austin <brian.austin@...rus.com>, linux-sound@...r.kernel.org,
	patches@...nsource.cirrus.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers
 automatic module loading

On Tue, Oct 21, 2025 at 09:12:13PM +0200, Alexander Sverdlin wrote:
> On Tue, 2025-10-21 at 20:00 +0100, Mark Brown wrote:

> > Or at least you'd get both modules loaded with one being redundant.  TBH

> I'm quite confident that udev/modprobe will load only the first module
> from modules.alias file.

Oh, I'm sure that's the case now but I can see someone changing that.

> > I'm very reluctant to touch this stuff for SPI without some very careful
> > analysis that it's not going to cause things to explode on people, right
> > now things seem to be working well enough so I'm not clear we'd be
> > solving an actual problem.

> The actual problem is that i2c-core is producing "of:" prefixed uevents
> instead of "i2c:" prefixed uevents starting from v4.18.

> Most of the dual-bus ASoC CODECs are affected.

That's a description of what change but not of a concrete problem that
users are experiencing.

> Now declaring "of:" to be the new I2C bus prefix for uevents starting from
> Linux v4.18 sounds strange.

I think a robust solution would involve having the OF aliases namespaced
by bus, or just not using the OF aliases but potentially having
collisions if two vendors pick the same device name.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)