linux-kernel - Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers automatic module loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d42ab1a0665f55731aabd1e9fcb31b8401b7913f.camel@gmail.com>
Date: Wed, 22 Oct 2025 19:46:26 +0200
From: Alexander Sverdlin <alexander.sverdlin@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Javier Martinez Canillas <javierm@...hat.com>, Wolfram Sang	
 <wsa@...-dreams.de>, Herve Codina <herve.codina@...tlin.com>, David Rhodes	
 <david.rhodes@...rus.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
 Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,  Conor Dooley
 <conor+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
 <tiwai@...e.com>,  Nikita Shubin <nikita.shubin@...uefel.me>, Axel Lin
 <axel.lin@...ics.com>, Brian Austin	 <brian.austin@...rus.com>,
 linux-sound@...r.kernel.org, 	patches@...nsource.cirrus.com,
 devicetree@...r.kernel.org, 	linux-kernel@...r.kernel.org, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers
 automatic module loading

Hi Mark,

On Wed, 2025-10-22 at 15:56 +0100, Mark Brown wrote:
> > > I'm very reluctant to touch this stuff for SPI without some very careful
> > > analysis that it's not going to cause things to explode on people, right
> > > now things seem to be working well enough so I'm not clear we'd be
> > > solving an actual problem.
> 
> > The actual problem is that i2c-core is producing "of:" prefixed uevents
> > instead of "i2c:" prefixed uevents starting from v4.18.
> 
> > Most of the dual-bus ASoC CODECs are affected.
> 
> That's a description of what change but not of a concrete problem that
> users are experiencing.

the concrete problem Herve has experienced is that cs4271-i2c will not be
loaded automatically starting with Linux v4.18 (commit af503716ac14
"i2c: core: report OF style module alias for devices registered via OF").

> > Now declaring "of:" to be the new I2C bus prefix for uevents starting from
> > Linux v4.18 sounds strange.
> 
> I think a robust solution would involve having the OF aliases namespaced
> by bus, or just not using the OF aliases but potentially having
> collisions if two vendors pick the same device name.

But this sounds like the situation before the above mentioned commit
af503716ac14, when both i2c and spi were symmetrically namespaced with
i2c: and spi: respectively and contained the "compatible" stripped of the
vendor prefix.

And I must admit that I had more understanding for the prior state of things.

-- 
Alexander Sverdlin.