linux-kernel - Re: [PATCH v5 3/3] irqchip: aspeed: add compatible strings for ast2700-intc0-ic and ast2700-intc1-ic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ecquyj5p.ffs@tglx>
Date: Wed, 22 Oct 2025 18:51:14 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Ryan Chen <ryan_chen@...eedtech.com>, ryan_chen
 <ryan_chen@...eedtech.com>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel
 Stanley <joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
 jk@...econstruct.com.au, Kevin Chen <kevin_chen@...eedtech.com>,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org
Subject: Re: [PATCH v5 3/3] irqchip: aspeed: add compatible strings for
 ast2700-intc0-ic and ast2700-intc1-ic

On Wed, Oct 22 2025 at 14:55, Ryan Chen wrote:

The subject prefix is: irqchip/aspeed-intc:

It's documented how to make them:

   https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject

> The AST2700 SoC defines two parent interrupt controller blocks
> (INTC0 and INTC1), each containing multiple interrupt-controller
> child instances ("*-intc-ic"). The existing irqchip driver
> (irq-aspeed-intc.c) currently only registers a single compatible
> string: "aspeed,ast2700-intc-ic"
>
> To support device trees that describe the INTC0 and INTC1
> hierarchy more precisely, this patch adds two additional

s/this patch adds/add/

git grep 'This patch' Documentation/process/

> compatible strings:
>  - "aspeed,ast2700-intc0-ic"
>  - "aspeed,ast2700-intc1-ic"
>
> Both map to the same initialization function
> `aspeed_intc_ic_of_init()`.

The backticks are pointless. Just write aspeed...init()

Thanks,

        tglx