| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<TY2PPF5CB9A1BE674594566C13B8D8B2984F2F0A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Date: Thu, 23 Oct 2025 06:57:01 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Rob Herring <robh@...nel.org>
CC: Thomas Gleixner <tglx@...utronix.de>, Krzysztof Kozlowski
<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
<joel@....id.au>, Andrew Jeffery <andrew@...econstruct.com.au>,
"jk@...econstruct.com.au" <jk@...econstruct.com.au>, Kevin Chen
<kevin_chen@...eedtech.com>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>
Subject: RE: [PATCH v5 1/3] dt-bindings: interrupt-controller: aspeed,ast2700:
Add support for INTC hierarchy
Hello Rob.
Thank you for your detailed review and comments.
> Subject: Re: [PATCH v5 1/3] dt-bindings: interrupt-controller: aspeed,ast2700:
> Add support for INTC hierarchy
>
> On Wed, Oct 22, 2025 at 02:55:05PM +0800, Ryan Chen wrote:
> > AST2700 contains two-level interrupt controllers (INTC0 and INTC1),
> > each with its own register space and handling different sets of
> > peripherals.
>
> This is a mess!
>
> How does this relate to the existing "aspeed,ast2700-intc-ic"? Its schema has a
> block diagram of connections which I can understand. This does not.
>
> The use of child nodes here is questionable. A variable number of interrupt
> banks is not a reason to have child nodes. I'm only guessing that's what's
> happening here because you haven't explained it.
Let me clarify the hardware structure and the purpose of these bindings.
The AST2700 SoC includes two top-level interrupt controller modules,
INTC0 and INTC1. (aspeed,ast2700-intc0, aspeed,ast2700-intc1)
Each of them provides routing selection and register protection
features.
Within each INTCx block, there are multiple sub-blocks called
intc-ic, each handling multi-interrupt sources.
("aspeed,ast2700-intc0-ic", "aspeed,ast2700-intc1-ic")
Cascading occurs between the child banks:
Level 1 : intc0-ic have multi-interrupts connect to GIC (root)
Level 2 : multi Intc1-ic# connect to intc0-ic
The parent intc0/1 nodes expose register regions for routing and
protection control, serving as containers for their intc-ic children.
The following simplified diagram shows the hierarchy:
+----------+ +----------+
| intc0 | | intc1 |
- - - - - - - - - - - - - - - - -+---- -----+- - - +------ - -+
+-----------------------+ | | | |
| +-------+ +---------+ | | | | |
| | | | | | | | | |
| | PSP +-+ GIC | | | | | |
| | | | | | | | | |
| +-------+ | | | | | | |
| | | | +----------+ | |
| | 192~201 <-|------+ <-------+ intc1-ic |
| +---------+ | | | | |
+-----------------------+ | intc0-ic <-------+ intc1-ic |
| | | |
| <-------+ intc1-ic |
+----------+ .....
>
> >
> > Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> > ---
> > .../aspeed,ast2700-intc0.yaml | 97
> +++++++++++++++++++
> > .../aspeed,ast2700-intc1.yaml | 94
> ++++++++++++++++++
> > 2 files changed, 191 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-
> > intc0.yaml create mode 100644
> > Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-
> > intc1.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc0.yaml
> > b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc0.yaml
> > new file mode 100644
> > index 000000000000..93a5b142b0a2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,as
> > +++ t2700-intc0.yaml
> > @@ -0,0 +1,97 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-int
> > +c0.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +maintainers:
> > + - Ryan Chen <ryan_chen@...eedtech.com>
> > +
> > +title: ASPEED AST2700 Interrupt Controller 0
> > +
> > +description:
> > + This interrupt controller hardware is first level interrupt
> > +controller that
> > + is hooked to the GIC interrupt controller. It's useful to combine
> > +multiple
> > + interrupt sources into 1 interrupt to GIC interrupt controller.
> > +
> > +properties:
> > + compatible:
> > + const: aspeed,ast2700-intc0
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 1
> > +
> > + ranges: true
> > +
> > +patternProperties:
> > + "^interrupt-controller@":
> > + type: object
> > + description: A child interrupt controller node
> > + additionalProperties: false
> > +
> > + properties:
> > + compatible:
> > + enum:
> > + - aspeed,ast2700-intc0-ic
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#interrupt-cells':
> > + const: 1
> > +
> > + interrupt-controller: true
> > +
> > + interrupts:
> > + minItems: 1
> > + maxItems: 10
>
> What are the 10 different interrupts? You have to define what each one is.
In currently design in level 1, intc0-ic connect 10 interrupts to CPU GIC.
So, should i use const:10 or I just use minItems: 1?
>
> > +
> > + required:
> > + - compatible
> > + - reg
> > + - interrupt-controller
> > + - '#interrupt-cells'
> > + - interrupts
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#address-cells'
> > + - '#size-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + intc0: interrupt-controller@...00000 {
>
> This node is not an interrupt-controller.
If can't use the interrupt-controller here.
What can I use? "intc0: controller@...00000" is ok ??
>
> > + compatible = "aspeed,ast2700-intc0";
> > + reg = <0x12100000 0x4000>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x0 0x12100000 0x4000>;
> > +
> > + intc0_11: interrupt-controller@...0 {
> > + #interrupt-cells = <1>;
> > + interrupt-controller;
> > + compatible = "aspeed,ast2700-intc0-ic";
> > + reg = <0x1b00 0x10>;
> > + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > + };
> > \ No newline at end of file
>
> Fix.
Will fix it in next version.
>
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc1.yaml
> > b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc1.yaml
> > new file mode 100644
> > index 000000000000..2f807d074211
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,as
> > +++ t2700-intc1.yaml
> > @@ -0,0 +1,94 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-int
> > +c1.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +maintainers:
> > + - Ryan Chen <ryan_chen@...eedtech.com>
> > +
> > +title: ASPEED AST2700 Interrupt Controller 1
> > +
> > +description:
> > + This interrupt controller hardware is second level interrupt
> > +controller that
> > + is hooked to a parent interrupt controller. It's useful to combine
> > +multiple
> > + interrupt sources into 1 interrupt to parent interrupt controller.
> > +
> > +properties:
> > + compatible:
> > + const: aspeed,ast2700-intc1
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#address-cells':
> > + const: 1
> > +
> > + '#size-cells':
> > + const: 1
> > +
> > + ranges: true
> > +
> > +patternProperties:
> > + "^interrupt-controller@":
> > + type: object
> > + description: A child interrupt controller node
> > + additionalProperties: false
> > +
> > + properties:
> > + compatible:
> > + enum:
> > + - aspeed,ast2700-intc1-ic
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + '#interrupt-cells':
> > + const: 1
> > +
> > + interrupt-controller: true
> > +
> > + interrupts-extended:
> > + minItems: 1
> > + maxItems: 1
> > +
> > + required:
> > + - compatible
> > + - reg
> > + - interrupt-controller
> > + - '#interrupt-cells'
> > + - interrupts-extended
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - '#address-cells'
> > + - '#size-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + intc1: interrupt-controller@...18000 {
> > + compatible = "aspeed,ast2700-intc1";
> > + reg = <0x14c18000 0x400>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x0 0x14c18000 0x400>;
> > +
> > + intc1_0: interrupt-controller@100 {
> > + compatible = "aspeed,ast2700-intc1-ic";
> > + reg = <0x100 0x10>;
> > + #interrupt-cells = <1>;
> > + interrupt-controller;
> > + interrupts-extended = <&intc0_11 0>;
> > + };
> > +
> > + intc1_1: interrupt-controller@110 {
> > + compatible = "aspeed,ast2700-intc1-ic";
> > + reg = <0x110 0x10>;
> > + #interrupt-cells = <1>;
> > + interrupt-controller;
> > + interrupts-extended = <&intc0_11 1>;
> > + };
> > + };
> > \ No newline at end of file
> > --
> > 2.34.1
> >
Powered by blists - more mailing lists