linux-kernel - Re: [PATCH v6 6/8] pinctrl: Add RTL8231 pin control and GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202510221215.irTQwvxA-lkp@intel.com>
Date: Wed, 22 Oct 2025 13:01:46 +0800
From: kernel test robot <lkp@...el.com>
To: Sander Vanheule <sander@...nheule.net>,
	Michael Walle <mwalle@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org,
	Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-leds@...r.kernel.org,
	devicetree@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Sander Vanheule <sander@...nheule.net>
Subject: Re: [PATCH v6 6/8] pinctrl: Add RTL8231 pin control and GPIO support

Hi Sander,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-mfd/for-mfd-next]
[also build test WARNING on lee-mfd/for-mfd-fixes linusw-pinctrl/devel linusw-pinctrl/for-next lee-leds/for-leds-next linus/master v6.18-rc2 next-20251021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sander-Vanheule/gpio-regmap-Force-writes-for-aliased-data-regs/20251021-222846
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
patch link:    https://lore.kernel.org/r/20251021142407.307753-7-sander%40svanheule.net
patch subject: [PATCH v6 6/8] pinctrl: Add RTL8231 pin control and GPIO support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20251022/202510221215.irTQwvxA-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251022/202510221215.irTQwvxA-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510221215.irTQwvxA-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/pinctrl/pinctrl-rtl8231.c: In function 'rtl8231_pinctrl_init_functions':
>> drivers/pinctrl/pinctrl-rtl8231.c:354:67: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
     354 |                 err = pinmux_generic_add_pinfunction(pctl, &func, (void *) flag);
         |                                                                   ^


vim +354 drivers/pinctrl/pinctrl-rtl8231.c

   321	
   322	static int rtl8231_pinctrl_init_functions(struct pinctrl_dev *pctl,
   323		const struct pinctrl_desc *pctl_desc)
   324	{
   325		struct pinfunction func;
   326		const char **groups;
   327		unsigned int f_idx;
   328		unsigned int flag;
   329		const char *name;
   330		unsigned int pin;
   331		int num_groups;
   332		int err;
   333	
   334		for (f_idx = 0; f_idx < ARRAY_SIZE(rtl8231_pin_functions); f_idx++) {
   335			name = rtl8231_pin_functions[f_idx].name;
   336			flag = rtl8231_pin_functions[f_idx].flag;
   337	
   338			for (pin = 0, num_groups = 0; pin < pctl_desc->npins; pin++)
   339				if (rtl8231_pin_data[pin].functions & flag)
   340					num_groups++;
   341	
   342			groups = devm_kcalloc(pctl->dev, num_groups, sizeof(*groups), GFP_KERNEL);
   343			if (!groups)
   344				return -ENOMEM;
   345	
   346			for (pin = 0, num_groups = 0; pin < pctl_desc->npins; pin++)
   347				if (rtl8231_pin_data[pin].functions & flag)
   348					groups[num_groups++] = rtl8231_pins[pin].name;
   349	
   350			func = PINCTRL_PINFUNCTION(name, groups, num_groups);
   351			if (flag == RTL8231_PIN_FUNCTION_GPIO)
   352				func.flags |= PINFUNCTION_FLAG_GPIO;
   353	
 > 354			err = pinmux_generic_add_pinfunction(pctl, &func, (void *) flag);
   355			if (err < 0)
   356				return err;
   357		}
   358	
   359		return 0;
   360	}
   361	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki