linux-kernel - Re: [PATCH 2/4] arm64: dts: imx8mp-phycore-som: add spi-nor supply vcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d935b1243b1256293b5a0b31069983ad56555407.camel@phytec.de>
Date: Wed, 22 Oct 2025 06:18:52 +0000
From: Yannic Moog <y.moog@...tec.de>
To: "Frank.li@....com" <Frank.li@....com>
CC: "kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"robh@...nel.org" <robh@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"upstream@...ts.phytec.de" <upstream@...ts.phytec.de>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 2/4] arm64: dts: imx8mp-phycore-som: add spi-nor supply
 vcc

On Mon, 2025-10-20 at 11:36 -0400, Frank Li wrote:
> On Mon, Oct 20, 2025 at 03:11:23PM +0200, Yannic Moog wrote:
> > The spi flash on the SoM is missing its vcc supply definition. Add
> > missing regulator which supplies the flash with 1.8V.
> > 
> > Signed-off-by: Yannic Moog <y.moog@...tec.de>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > index 88831c0fbb7be3db18910385e4e15691b1c74ef2..d370e2a3a00c5e3e91a606ac0fbed30cf5e6f9b2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > @@ -28,6 +28,15 @@ reg_vdd_io: regulator-vdd-io {
> >  		regulator-min-microvolt = <3300000>;
> >  		regulator-name = "VDD_IO";
> >  	};
> > +
> > +	reg_vdd_1v8: regulator-vdd-1v8 {
> > +		compatible = "regulator-fixed";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> 
> Needn't regulator-always-on and regulator-boot-on because it is refered
> by flash@0.

I added these properties to make it clear for the reader that this regulator is not Software
controlled and should not be disabled. Imo this is part of hardware description.
Should I remove the properties?

Yannic

> 
> Frank
> 
> > +		regulator-max-microvolt = <1800000>;
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-name = "VDD_1V8";
> > +	};
> >  };
> > 
> >  &A53_0 {
> > @@ -83,6 +92,7 @@ som_flash: flash@0 {
> >  		spi-max-frequency = <80000000>;
> >  		spi-rx-bus-width = <4>;
> >  		spi-tx-bus-width = <1>;
> > +		vcc-supply = <&reg_vdd_1v8>;
> >  	};
> >  };
> > 
> > 
> > --
> > 2.51.0
> >