linux-kernel - Re: [PATCH 1/3] dt-bindings: mfd: twl: enable power button also for twl603x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251022105516.2ffea183@kemnade.info>
Date: Wed, 22 Oct 2025 10:55:16 +0200
From: Andreas Kemnade <andreas@...nade.info>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Dmitry
 Torokhov <dmitry.torokhov@...il.com>, Tony Lindgren <tony@...mide.com>,
 Kevin Hilman <khilman@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
 linux-omap@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mfd: twl: enable power button also for
 twl603x

On Tue, 21 Oct 2025 19:18:25 +0200
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> On 21/10/2025 18:36, Andreas Kemnade wrote:
> > On Tue, 21 Oct 2025 11:58:49 +0200
> > Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >   
> >> On 21/10/2025 10:45, Andreas Kemnade wrote:  
> >>> On Tue, 21 Oct 2025 09:10:28 +0200
> >>> Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>>     
> >>>> On 20/10/2025 14:31, akemnade@...nel.org wrote:    
> >>>>> From: Andreas Kemnade <andreas@...nade.info>
> >>>>>
> >>>>> TWL603x has also a power button, so add the corresponding subnode.      
> >>>>
> >>>> No, we don't add subnodes just because there is a power button. This
> >>>> needs broader explanation, see also my further comment.
> >>>>    
> >>> Hmm, what is the general pattern to follow if a mfd device has some
> >>> functionality which depends on some optional external components?    
> >>
> >> Please describe it better - how these nodes depend on external
> >> component? The power button logic/IC is in this device always. It is not
> >> optional.
> >>  
> > The power button logic is always there, yes, but it depends on an optional
> > actual mechanical button connected to a pad of this device, which is
> > not always there. The logic will not work if I just put my finger on the PMIC,
> > but it will work if there is a mechanical button which I can press connected to
> > the PMIC.  
> 
> 
> Hm... how do you represent this logic now? By adding status=disabled to
> the pwrbutton node?
> 
Yes, or by simply not adding tho pwrbutton node at all. Well, if we break
the legacy pattern here, we can probably add a property for this.


Regards,
Andreas