| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251022144422.7c17322a@kemnade.info> Date: Wed, 22 Oct 2025 14:44:22 +0200 From: Andreas Kemnade <andreas@...nade.info> To: Dmitry Torokhov <dmitry.torokhov@...il.com> Cc: akemnade@...nel.org, Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Tony Lindgren <tony@...mide.com>, Kevin Hilman <khilman@...nel.org>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, linux-omap@...r.kernel.org Subject: Re: [PATCH 2/3] Input: add TWL603x power button On Tue, 21 Oct 2025 10:58:35 -0700 Dmitry Torokhov <dmitry.torokhov@...il.com> wrote: > On Mon, Oct 20, 2025 at 02:31:59PM +0200, akemnade@...nel.org wrote: > > From: Andreas Kemnade <andreas@...nade.info> > > > > Like the TWL4030, these PMICs also have a power button feature, so add > > a driver for it. > > Could it be integrated into twl4030-pwrbutton.c? I think the differences > can be accounted for via a "chip" structure attached to a compatible... > So what is different: - different register (but same bit) - some custom irq stuff for 603x (so if (is_603x) needed) - different name for the button (can be neglected I think) Besides of adding a chip structure we can do it the same way as rtc-twl.c is doing: using twl_class_is_xxxx() which derives its return from the parents compatible. It is simplier, but I think the chip structure does not hurt much either. Regards, Andreas
Powered by blists - more mailing lists