linux-kernel - Re: [PATCH v6 RESEND] media: pci: intel: ivsc: improve device reference counting in mei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPiqDLFcnOm4qu1Y@kekkonen.localdomain>
Date: Wed, 22 Oct 2025 12:55:24 +0300
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Ma Ke <make24@...as.ac.cn>
Cc: bingbu.cao@...el.com, lixu.zhang@...el.com, mchehab@...nel.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH v6 RESEND] media: pci: intel: ivsc: improve device
 reference counting in mei_ace driver

Hi Ma,

On Wed, Oct 22, 2025 at 05:25:45PM +0800, Ma Ke wrote:
> Put the reference to csi_dev acquired during driver probe in
> mei_ace_setup_dev_link() inside the same function, instead of during
> driver unbind in mei_ace_remove(). This can be done as
> device_link_add() already takes a reference to csi_dev.
> 
> Found by code review.
> 
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
> Changes in v6:
> - modified the commit message as suggestions;
> Changes in v5:
> - jumped to err instead of err_put to avoid calling put_device() again in err_put as reviewer's instructions;
> Changes in v4:
> - updated the subject as suggestions;
> Changes in v3:
> - deleted the tag of Fixes and CC, and moved put_device() to immediately after device_link_add() as suggestions;
> Changes in v2:
> - modified the put_device() operations and the patch title as suggestions.

v5 of this patch has been already merged with a modified commit message;
there's no need to resend this anymore.

-- 
Kind regards,

Sakari Ailus