linux-kernel - Re: [PATCH] iio: accel: bma220: move set_wdt() out of bma220

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPjE-n0wKNIJd2-M@smile.fi.intel.com>
Date: Wed, 22 Oct 2025 14:50:18 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Petre Rodan <petre.rodan@...dimension.ro>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: accel: bma220: move set_wdt() out of bma220_core

On Tue, Oct 21, 2025 at 01:31:49PM +0300, Petre Rodan wrote:
> Move bma220_set_wdt() into bma220_i2c.c instead of using a conditional
> based on i2c_verify_client() in bma220_core.c that would make core
> always depend on the i2c module.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

But Kconfig for this driver is a bit strange. Usually we do other way around,
i.e. make user visible selection of the glue drivers, while core is selected if
at least one of the leaf driver selected by the user.

-- 
With Best Regards,
Andy Shevchenko