linux-kernel - Re: [PATCH] iio: accel: bma220: move set_wdt() out of bma220

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251023182318.00004319@huawei.com>
Date: Thu, 23 Oct 2025 18:23:18 +0100
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC: Petre Rodan <petre.rodan@...dimension.ro>, Jonathan Cameron
	<jic23@...nel.org>, David Lechner <dlechner@...libre.com>, Nuno
 Sá <nuno.sa@...log.com>, Andy Shevchenko
	<andy@...nel.org>, <linux-iio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] iio: accel: bma220: move set_wdt() out of bma220_core

On Wed, 22 Oct 2025 14:50:18 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Tue, Oct 21, 2025 at 01:31:49PM +0300, Petre Rodan wrote:
> > Move bma220_set_wdt() into bma220_i2c.c instead of using a conditional
> > based on i2c_verify_client() in bma220_core.c that would make core
> > always depend on the i2c module.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> But Kconfig for this driver is a bit strange. Usually we do other way around,
> i.e. make user visible selection of the glue drivers, while core is selected if
> at least one of the leaf driver selected by the user.
> 
This comes up from time to time.  There kind of isn't a right answer
to my mind in the trade off between complexity of configuration 
and desire for minimum useful set of Kconfig symbols and people wanting
to build only exactly what they want.  So we've ended up with a mix.

I don't mind setting a policy on this for new code going forwards, but
that means we need to decide which approach we prefer and document
it somewhere.

Jonathan