linux-kernel - Re: [PATCH v2 2/2] iio: pressure: adp810: Add driver for adp810 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251023182537.000069be@huawei.com>
Date: Thu, 23 Oct 2025 18:25:37 +0100
From: Jonathan Cameron <jonathan.cameron@...wei.com>
To: Akhilesh Patil <akhilesh@...iitb.ac.in>
CC: Jonathan Cameron <jic23@...nel.org>, <dlechner@...libre.com>,
	<robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<nuno.sa@...log.com>, <andy@...nel.org>, <marcelo.schmitt1@...il.com>,
	<vassilisamir@...il.com>, <salah.triki@...il.com>,
	<skhan@...uxfoundation.org>, <linux-iio@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<akhileshpatilvnit@...il.com>
Subject: Re: [PATCH v2 2/2] iio: pressure: adp810: Add driver for adp810
 sensor

On Tue, 21 Oct 2025 11:15:42 +0530
Akhilesh Patil <akhilesh@...iitb.ac.in> wrote:

> On Sat, Oct 18, 2025 at 05:47:46PM +0100, Jonathan Cameron wrote:
> > On Mon, 13 Oct 2025 22:32:35 +0530
> > Akhilesh Patil <akhilesh@...iitb.ac.in> wrote:
> >   
> > > Add driver for Aosong adp810 differential pressure and temperature sensor.
> > > This sensor provides an I2C interface for reading data.
> > > Calculate CRC of the data received using standard crc8 library to verify
> > > data integrity.
> > > 
> > > Tested on TI am62x sk board with sensor connected at i2c-2.
> > > 
> > > Signed-off-by: Akhilesh Patil <akhilesh@...iitb.ac.in>  
> > 
> > A few comments inline and it seems your rebase when wrong and you've
> > picked up unrelated build file changes.
> > 
> > Thanks
> > 
> > Jonathan  
> 
> Hi Jonathan, Thanks for the review, I will share v3 addressing these comments.
> 
> Regards,
> Akhilesh
> 
> >   
> > > diff --git a/drivers/iio/pressure/Makefile b/drivers/iio/pressure/Makefile
> > > index 6482288e07ee..a21443e992b9 100644
> > > --- a/drivers/iio/pressure/Makefile
> > > +++ b/drivers/iio/pressure/Makefile
> > > @@ -5,6 +5,7 @@
> > >  
> > >  # When adding new entries keep the list in alphabetical order
> > >  obj-$(CONFIG_ABP060MG) += abp060mg.o
> > > +obj-$(CONFIG_ADP810) += adp810.o
> > >  obj-$(CONFIG_ROHM_BM1390) += rohm-bm1390.o
> > >  obj-$(CONFIG_BMP280) += bmp280.o
> > >  bmp280-objs := bmp280-core.o bmp280-regmap.o
> > > @@ -15,6 +16,7 @@ obj-$(CONFIG_DPS310) += dps310.o
> > >  obj-$(CONFIG_IIO_CROS_EC_BARO) += cros_ec_baro.o
> > >  obj-$(CONFIG_HID_SENSOR_PRESS)   += hid-sensor-press.o
> > >  obj-$(CONFIG_HP03) += hp03.o
> > > +obj-$(CONFIG_HP206C) += hp206c.o
> > >  obj-$(CONFIG_HSC030PA) += hsc030pa.o
> > >  obj-$(CONFIG_HSC030PA_I2C) += hsc030pa_i2c.o
> > >  obj-$(CONFIG_HSC030PA_SPI) += hsc030pa_spi.o
> > > @@ -34,11 +36,9 @@ obj-$(CONFIG_SDP500) += sdp500.o
> > >  obj-$(CONFIG_IIO_ST_PRESS) += st_pressure.o
> > >  st_pressure-y := st_pressure_core.o
> > >  st_pressure-$(CONFIG_IIO_BUFFER) += st_pressure_buffer.o
> > > +obj-$(CONFIG_IIO_ST_PRESS_I2C) += st_pressure_i2c.o
> > > +obj-$(CONFIG_IIO_ST_PRESS_SPI) += st_pressure_spi.o
> > >  obj-$(CONFIG_T5403) += t5403.o
> > > -obj-$(CONFIG_HP206C) += hp206c.o  
> > 
> > Rebase gone wrong I assume.    
> 
> These are intentional changes.
> 
> This addresses Andy's suggestion in v1, to keep entries alphabetically
> arranged in Makefile. Along with adp810 location, fixed other files as well
> hp206 and st_pressure_* to make entries alphabetically arranged in
> the entire Makefile.

That reorder of others needs to be a separate patch so that it can
explicitly call out that it is tidying up ordering.

Jonathan