linux-kernel - Re: [PATCH v9 1/3] i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPp1NRDgBwemLfs1@smile.fi.intel.com>
Date: Thu, 23 Oct 2025 21:34:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: andi.shyti@...nel.org, wsa+renesas@...g-engineering.com,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 1/3] i2c: pcf8584: Move 'ret' variable inside for
 loop, goto out if ret < 0.

On Thu, Oct 23, 2025 at 03:00:41PM +0300, Cezar Chiru wrote:
> Require spaces around '=' and '<'. Add spaces around binary operators.
> Enforce error fixing based on checkpatch.pl output on file.
> Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> improves usage of ret variable.

...

> Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>

I haven't suggested much, but if you insist in the tag I won't object.

-- 
With Best Regards,
Andy Shevchenko