linux-kernel - Re: [PATCH v9 1/3] i2c: pcf8584: Move 'ret' variable inside for loop, goto out if ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dnjved3kd3awdseclr56mbwxkbuysxcezzbebrk7fjpuq2kf2p@rhat4xhdao52>
Date: Fri, 24 Oct 2025 12:57:41 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Cezar Chiru <chiru.cezar.89@...il.com>
Cc: wsa+renesas@...g-engineering.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Andy Shevchenko <andriy.shevchenko@...el.com>
Subject: Re: [PATCH v9 1/3] i2c: pcf8584: Move 'ret' variable inside for
 loop, goto out if ret < 0.

Hi Cezar,

On Thu, Oct 23, 2025 at 03:00:41PM +0300, Cezar Chiru wrote:
> Require spaces around '=' and '<'. Add spaces around binary operators.
> Enforce error fixing based on checkpatch.pl output on file.
> Move 'ret' variable inside for loop. Then check if (ret < 0) goto out. This
> improves usage of ret variable.
> 
> Signed-off-by: Cezar Chiru <chiru.cezar.89@...il.com>
> Suggested-by: Andi Shyti <andi.shyti@...nel.org>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>

you don't really need to resend patches for updating the tag
list. Anyway, that's OK, better to send than not to send, when in
doubt, ask.

For this patch I think neither me or Andy have been suggesting
the change. The change came from you, we made observation which
you applied, this is the normal review process.

If you don't mind, I'm going to remove them when applying (let me
know if you don't agree). No need to resend.

Andi