linux-kernel - Re: [PATCH] staging: greybus: fw-download: Fix find firmware req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202510231209.JEFfW9s0-lkp@intel.com>
Date: Thu, 23 Oct 2025 12:57:03 +0800
From: kernel test robot <lkp@...el.com>
To: Ayush Singh <ayush@...gleboard.org>,
	Jason Kridner <jkridner@...gleboard.org>,
	Deepak Khatri <lorforlinux@...gleboard.org>,
	Robert Nelson <robertcnelson@...gleboard.org>,
	Dhruva Gole <d-gole@...com>, Viresh Kumar <vireshk@...nel.org>,
	Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: oe-kbuild-all@...ts.linux.dev, greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Ayush Singh <ayush@...gleboard.org>
Subject: Re: [PATCH] staging: greybus: fw-download: Fix find firmware req

Hi Ayush,

kernel test robot noticed the following build warnings:

[auto build test WARNING on aaa9c3550b60d6259d6ea8b1175ade8d1242444e]

url:    https://github.com/intel-lab-lkp/linux/commits/Ayush-Singh/staging-greybus-fw-download-Fix-find-firmware-req/20251022-153520
base:   aaa9c3550b60d6259d6ea8b1175ade8d1242444e
patch link:    https://lore.kernel.org/r/20251022-gb-fw-v1-1-183b18500cd5%40beagleboard.org
patch subject: [PATCH] staging: greybus: fw-download: Fix find firmware req
config: arm64-randconfig-002-20251023 (https://download.01.org/0day-ci/archive/20251023/202510231209.JEFfW9s0-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510231209.JEFfW9s0-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510231209.JEFfW9s0-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/greybus/fw-download.c:14:
   drivers/staging/greybus/fw-download.c: In function 'gb_fw_download_request_handler':
>> drivers/staging/greybus/firmware.h:14:24: warning: '%s' directive output may be truncated writing up to 9 bytes into a region of size between 6 and 15 [-Wformat-truncation=]
    #define FW_NAME_PREFIX "gmp_"
                           ^~~~~~
   drivers/staging/greybus/fw-download.c:188:5: note: in expansion of macro 'FW_NAME_PREFIX'
        FW_NAME_PREFIX "%08x_%08x_%08x_%08x_%s.%s",
        ^~~~~~~~~~~~~~
   drivers/staging/greybus/fw-download.c:188:44: note: format string is defined here
        FW_NAME_PREFIX "%08x_%08x_%08x_%08x_%s.%s",
                                               ^~
   drivers/staging/greybus/fw-download.c:187:3: note: 'snprintf' output between 42 and 60 bytes into a destination of size 56
      snprintf(fw_req->name, sizeof(fw_req->name),
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        FW_NAME_PREFIX "%08x_%08x_%08x_%08x_%s.%s",
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        intf->ddbl1_manufacturer_id, intf->ddbl1_product_id,
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        intf->vendor_id, intf->product_id, tag, format);
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +14 drivers/staging/greybus/firmware.h

cca222076738962 Viresh Kumar       2016-04-28  13  
350e3ac2ceb6964 Joel Porquet       2016-07-21 @14  #define FW_NAME_PREFIX	"gmp_"
8a704565ebda960 Greg Kroah-Hartman 2016-07-20  15  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki