linux-kernel - Re: [PATCH] keys: Fix typos in 'struct key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E9856573-8D4D-4392-9AE5-5D40D1FC13F9@linux.dev>
Date: Fri, 24 Oct 2025 22:29:57 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: David Howells <dhowells@...hat.com>,
 keyrings@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] keys: Fix typos in 'struct key_type' function pointer
 comments

On 24. Oct 2025, at 21:04, Jarkko Sakkinen wrote:
> On Thu, Oct 16, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:
>> s/it/if/ and s/revokation/revocation/
>> ...
> 
> The comment is also formatted incorrectly. It should be:
> 
> 	/* 
> 	 * Free preparsed match data (optional).  This should be supplied if
> 	 * ->match_preparse() is supplied. 
> 	 */

The other struct fields are all commented with the first sentence
starting after the '/*'.

I can fix this one trailing '*/' in v2, but the others should probably
be fixed in a separate patch?

Thanks,
Thorsten