linux-kernel - Re: [PATCH] keys: Fix typos in 'struct key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aP_R2ycWjzRWEV8V@kernel.org>
Date: Mon, 27 Oct 2025 22:11:07 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] keys: Fix typos in 'struct key_type' function pointer
 comments

On Fri, Oct 24, 2025 at 10:29:57PM +0200, Thorsten Blum wrote:
> On 24. Oct 2025, at 21:04, Jarkko Sakkinen wrote:
> > On Thu, Oct 16, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:
> >> s/it/if/ and s/revokation/revocation/
> >> ...
> > 
> > The comment is also formatted incorrectly. It should be:
> > 
> > 	/* 
> > 	 * Free preparsed match data (optional).  This should be supplied if
> > 	 * ->match_preparse() is supplied. 
> > 	 */
> 
> The other struct fields are all commented with the first sentence
> starting after the '/*'.
> 
> I can fix this one trailing '*/' in v2, but the others should probably
> be fixed in a separate patch?

We don't want to batch update to all comments in this file as that e.g.
has more drawbacks than benefits because it increases the probability
of merge conflicts during backports.

I.e.

1. Refine the patch to address the remark that were anyhow modified.
2. Don't update any other comments just for the remark I did.
> 
> Thanks,
> Thorsten
> 


BR, Jarkko