linux-kernel - Re: [PATCH] spi: imx: add 16/32 bits per word support for target mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251024-berserk-stirring-copperhead-3783be-mkl@pengutronix.de>
Date: Fri, 24 Oct 2025 09:12:36 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: carlos.song@....com
Cc: frank.li@....com, broonie@...nel.org, shawnguo@...nel.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: imx: add 16/32 bits per word support for target mode

On 24.10.2025 13:49:52, carlos.song@....com wrote:
> From: Clark Wang <xiaoning.wang@....com>
> 
> Now for ECSPI only support 8 bits per word in target mode.
> Enable 16/32 bits per word support for spi-imx target mode.
> 
> Signed-off-by: Carlos Song <carlos.song@....com>
> Signed-off-by: Clark Wang <xiaoning.wang@....com>
> ---
>  drivers/spi/spi-imx.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> index 155ddeb8fcd4..4ffee6c5d5c4 100644
> --- a/drivers/spi/spi-imx.c
> +++ b/drivers/spi/spi-imx.c
> @@ -424,8 +424,12 @@ static void spi_imx_buf_tx_swap(struct spi_imx_data *spi_imx)
>  
>  static void mx53_ecspi_rx_target(struct spi_imx_data *spi_imx)
>  {
> -	u32 val = ioread32be(spi_imx->base + MXC_CSPIRXDATA);
> +	u32 val = readl(spi_imx->base + MXC_CSPIRXDATA);
>  
> +	if (spi_imx->bits_per_word <= 8)
> +		val = be32_to_cpu(val);
> +	else if (spi_imx->bits_per_word <= 16)
> +		val = (val << 16) | (val >> 16);

You can use swahw32() here and below.

>  	if (spi_imx->rx_buf) {
>  		int n_bytes = spi_imx->target_burst % sizeof(val);
>  
> @@ -453,12 +457,16 @@ static void mx53_ecspi_tx_target(struct spi_imx_data *spi_imx)
>  	if (spi_imx->tx_buf) {
>  		memcpy(((u8 *)&val) + sizeof(val) - n_bytes,
>  		       spi_imx->tx_buf, n_bytes);
> +		if (spi_imx->bits_per_word <= 8)
> +			val = cpu_to_be32(val);
> +		else if (spi_imx->bits_per_word <= 16)
> +			val = (val << 16) | (val >> 16);

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)