linux-kernel - [PATCH v3 2/2] nvme-pci: Add debug message on fail to read CSTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251024-nvme_probefail-v3-2-5386f905378b@linux.ibm.com>
Date: Fri, 24 Oct 2025 13:05:32 +0200
From: Gerd Bayer <gbayer@...ux.ibm.com>
To: Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>
Cc: Niklas Schnelle <schnelle@...ux.ibm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Wilfred Mallawa <wilfred.mallawa@....com>,
        John Garry <john.g.garry@...cle.com>, linux-nvme@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Gerd Bayer <gbayer@...ux.ibm.com>
Subject: [PATCH v3 2/2] nvme-pci: Add debug message on fail to read CSTS

Add a debug log spelling out that reading the CSTS register failed - to
distinguish this from other reasons for ENODEV.

Reviewed-by: Wilfred Mallawa <wilfred.mallawa@....com>
Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>
Reviewed-by: Christoph Hellwig <hch@....de>
Signed-off-by: Gerd Bayer <gbayer@...ux.ibm.com>
---
 drivers/nvme/host/pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 8c624960c9f67e0cc8409023de5e532d6ed9b3ac..15c12e6cba884a9bb5248f70d75490254014b9f9 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2906,6 +2906,7 @@ static int nvme_pci_enable(struct nvme_dev *dev)
 	pci_set_master(pdev);
 
 	if (readl(dev->bar + NVME_REG_CSTS) == -1) {
+		dev_dbg(dev->ctrl.device, "reading CSTS register failed\n");
 		result = -ENODEV;
 		goto disable;
 	}

-- 
2.48.1