linux-kernel - Re: [PATCH v3 1/2] nvme-pci: Print error message on failure in nvme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4539e32df948119ee7a7e77cf67d263e488236f9.camel@wdc.com>
Date: Sun, 26 Oct 2025 07:20:52 +0000
From: Wilfred Mallawa <wilfred.mallawa@....com>
To: "kbusch@...nel.org" <kbusch@...nel.org>, "gbayer@...ux.ibm.com"
	<gbayer@...ux.ibm.com>, "axboe@...nel.dk" <axboe@...nel.dk>,
	"sagi@...mberg.me" <sagi@...mberg.me>, hch <hch@....de>
CC: "john.g.garry@...cle.com" <john.g.garry@...cle.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"schnelle@...ux.ibm.com" <schnelle@...ux.ibm.com>,
	"linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
	"kch@...dia.com" <kch@...dia.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] nvme-pci: Print error message on failure in
 nvme_probe

On Fri, 2025-10-24 at 13:05 +0200, Gerd Bayer wrote:
> Add a new error message that makes failures to probe visible in the
> kernel log, like:
> nvme 0008:00:00.0: error -ENODEV: probe failed
> 
> This highlights issues with a particular device right away instead of
> leaving users to search for missing drives.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Gerd Bayer <gbayer@...ux.ibm.com>
> ---
>  drivers/nvme/host/pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index
> c916176bd9f058b49e6e6768675711df52b15765..8c624960c9f67e0cc8409023de5
> e532d6ed9b3ac 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3522,6 +3522,7 @@ static int nvme_probe(struct pci_dev *pdev,
> const struct pci_device_id *id)
>  	nvme_uninit_ctrl(&dev->ctrl);
>  out_put_ctrl:
>  	nvme_put_ctrl(&dev->ctrl);
> +	dev_err_probe(&pdev->dev, result, "probe failed\n");
>  	return result;
>  }
>  
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@....com>

Regards,
Wilfred