linux-kernel - Re: [PATCH] fs/9p: delete unnnecessary condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13655400.bYd4YqkHfl@silver>
Date: Fri, 24 Oct 2025 13:59:46 +0200
From: Christian Schoenebeck <linux_oss@...debyte.com>
To: Dominique Martinet <asmadeus@...ewreck.org>,
 Eric Van Hensbergen <ericvh@...nel.org>,
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: Latchesar Ionkov <lucho@...kov.net>, v9fs@...ts.linux.dev,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] fs/9p: delete unnnecessary condition

On Friday, October 24, 2025 1:26:00 PM CEST Dan Carpenter wrote:
> We already know that "retval" is negative, so there is no need to check
> again.  Also the statement is not indented far enough.  Delete it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---

Fixes: 43c36a5
Reviewed-by: Christian Schoenebeck <linux_oss@...debyte.com>

Apparently a manual revert copy paste error. The rest of the revert commit
LGTM.

/Christian

>  fs/9p/vfs_dentry.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/9p/vfs_dentry.c b/fs/9p/vfs_dentry.c
> index c1acbc98465d..c5bf74d547e8 100644
> --- a/fs/9p/vfs_dentry.c
> +++ b/fs/9p/vfs_dentry.c
> @@ -109,7 +109,6 @@ static int __v9fs_lookup_revalidate(struct dentry
> *dentry, unsigned int flags) p9_debug(P9_DEBUG_VFS,
>  				"refresh inode: dentry = %pd (%p), got error %pe\n",
>  				dentry, dentry, ERR_PTR(retval));
> -		if (retval < 0)
>  			return retval;
>  		}
>  	}