[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<TY2PPF5CB9A1BE63500EA8CE65A0DE7A781F2F1A@TY2PPF5CB9A1BE6.apcprd06.prod.outlook.com>
Date: Fri, 24 Oct 2025 12:36:33 +0000
From: Ryan Chen <ryan_chen@...eedtech.com>
To: Jeremy Kerr <jk@...econstruct.com.au>, Krzysztof Kozlowski
<krzk@...nel.org>
CC: "benh@...nel.crashing.org" <benh@...nel.crashing.org>, "joel@....id.au"
<joel@....id.au>, "andi.shyti@...nel.org" <andi.shyti@...nel.org>,
"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
"andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
"naresh.solanki@...ements.com" <naresh.solanki@...ements.com>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a
new YAML
> Subject: Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new
> YAML
>
> Hi Kyzysztof,
>
> > > Not much different than every other soc. All of them are separate
> > > IPs.
> > > Look at any Samsung, NXP or Qualcomm binding. Separate IPs.
> >
> >
> > So let the move happen, but please explain in the commit msg that
> > devices are completely different - nothing in common - and thus the
> > binding will be different. We indeed do not keep completely different
> > devices in one binding, but based on commit msg I had impression this
> > was just major block upgrade.
>
> OK, makes sense.
>
> Ryan, let me know if you need a hand with the commit message changes.
>
Thanks Jeremy and Krzysztof,
If I modify the commit message as follows, would that make it clearer?
The AST2600 I2C controller introduces a completely new register map and
Separate control/target register sets, unlike the mixed layout used in
AST2400/AST2500. In addition, at new AST2600 configuration registers
and transfer modes require new DT properties, which are incompatible
with existing bindings. Therefore, this patch creates a dedicated binding
file for AST2600 to properly describe these new hardware capabilities.
> Cheers,
>
>
> Jeremy
Powered by blists - more mailing lists