linux-kernel - Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4e06ef2-e3d5-49ad-83f3-9daf2e08e88d@kernel.org>
Date: Fri, 24 Oct 2025 14:43:24 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>,
 Jeremy Kerr <jk@...econstruct.com.au>
Cc: "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
 "joel@....id.au" <joel@....id.au>,
 "andi.shyti@...nel.org" <andi.shyti@...nel.org>,
 "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
 <krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
 "andrew@...econstruct.com.au" <andrew@...econstruct.com.au>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
 "naresh.solanki@...ements.com" <naresh.solanki@...ements.com>,
 "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
 "openbmc@...ts.ozlabs.org" <openbmc@...ts.ozlabs.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a
 new YAML

On 24/10/2025 14:36, Ryan Chen wrote:
>> Subject: Re: [PATCH v20 1/4] dt-bindings: i2c: Split AST2600 binding into a new
>> YAML
>>
>> Hi Kyzysztof,
>>
>>>> Not much different than every other soc. All of them are separate
>>>> IPs.
>>>> Look at any Samsung, NXP or Qualcomm binding. Separate IPs.
>>>
>>>
>>> So let the move happen, but please explain in the commit msg that
>>> devices are completely different - nothing in common - and thus the
>>> binding will be different. We indeed do not keep completely different
>>> devices in one binding, but based on commit msg I had impression this
>>> was just major block upgrade.
>>
>> OK, makes sense.
>>
>> Ryan, let me know if you need a hand with the commit message changes.
>>
> Thanks Jeremy and Krzysztof,
> 
> If I modify the commit message as follows, would that make it clearer?
> 
> The AST2600 I2C controller introduces a completely new register map and
> Separate control/target register sets, unlike the mixed layout used in
> AST2400/AST2500. In addition, at new AST2600 configuration registers
> and transfer modes require new DT properties, which are incompatible
> with existing bindings. Therefore, this patch creates a dedicated binding
> file for AST2600 to properly describe these new hardware capabilities.

It's fine.

Best regards,
Krzysztof