linux-kernel - Re: [PATCH net-next] dt-bindings: net: phy: vsc8531: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CA+V-a8svLWD+qGTATNS5b4_4Oo7QuW2=v8jMZyNn-hJx99C_tQ@mail.gmail.com>
Date: Sat, 25 Oct 2025 05:20:08 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Heiko Stuebner <heiko@...ech.de>, devicetree@...r.kernel.org, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH net-next] dt-bindings: net: phy: vsc8531: Convert to DT schema

Hi Rob,

Thank you for the review.

On Sat, Oct 25, 2025 at 12:20 AM Rob Herring <robh@...nel.org> wrote:
>
> On Fri, Oct 24, 2025 at 09:18:36PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Convert VSC8531 Gigabit ethernet phy binding to DT schema format. While
> > at it add compatible string for VSC8541 PHY which is very much similar
> > to the VSC8531 PHY and is already supported in the kernel. VSC8541 PHY
> > is present on the Renesas RZ/T2H EVK.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > Inspired from the DT warnings seen while running dtbs check [0],
> > took an opportunity to convert this binding to DT schema format.
> > As there was no entry in the maintainers file Ive added myself
> > as the maintainer for this binding.
> > [0] https://lore.kernel.org/all/176073765433.419659.2490051913988670515.robh@kernel.org/
> >
> > Note,
> > 1] dt_binding_check reports below warnings. But this looks like
> > the same for other DT bindings too which have dependencies defined.
> > ./Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml:99:36: [warning] too few spaces after comma (commas)
> > <path>/mscc-phy-vsc8531.example.dtb: ethernet-phy@0 (ethernet-phy-id0007.0772): 'vsc8531' is a dependency of 'vsc8531,edge-slowdown'
> >       from schema $id: http://devicetree.org/schemas/net/mscc-phy-vsc8531.yaml
> > <path>/mscc-phy-vsc8531.example.dtb: ethernet-phy@0 (ethernet-phy-id0007.0772): 'vddmac' is a dependency of 'vsc8531,edge-slowdown'
> > 2] As there is no entry in maintainers file for this binding, Ive added myself
> > as the maintainer for this binding.
> > ---
> >  .../bindings/net/mscc-phy-vsc8531.txt         |  73 ----------
> >  .../bindings/net/mscc-phy-vsc8531.yaml        | 125 ++++++++++++++++++
> >  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +-
> >  3 files changed, 126 insertions(+), 74 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> >  create mode 100644 Documentation/devicetree/bindings/net/mscc-phy-vsc8531.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> > deleted file mode 100644
> > index 0a3647fe331b..000000000000
> > --- a/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt
> > +++ /dev/null
> > @@ -1,73 +0,0 @@
> > -* Microsemi - vsc8531 Giga bit ethernet phy
> > -
<snip>
> > +$id: http://devicetree.org/schemas/net/mscc-phy-vsc8531.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Microsemi VSC8531 Gigabit Ethernet PHY
> > +
> > +maintainers:
> > +  - Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > +
> > +description:
> > +  The VSC8531 is a Gigabit Ethernet PHY with configurable MAC interface
> > +  drive strength and LED modes.
> > +
> > +allOf:
> > +  - $ref: ethernet-phy.yaml#
> > +
> > +select:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        enum:
> > +          - ethernet-phy-id0007.0570 # VSC8531
> > +          - ethernet-phy-id0007.0772 # VSC8541
> > +  required:
> > +    - compatible
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - ethernet-phy-id0007.0570 # VSC8531
> > +          - ethernet-phy-id0007.0772 # VSC8541
> > +      - const: ethernet-phy-ieee802.3-c22
> > +
> > +  vsc8531,vddmac:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
> > +      The VDDMAC voltage in millivolts. This property is used in combination
> > +      with the edge-slowdown property to control the drive strength of the
> > +      MAC interface output signals.
> > +    enum: [3300, 2500, 1800, 1500]
> > +    default: 3300
> > +
> > +  vsc8531,edge-slowdown:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description:
>
> Use '>' if you have formatting.
>
OK.

> > +      Percentage by which the edge rate should be slowed down relative to
> > +      the fastest possible edge time. This setting helps reduce electromagnetic
> > +      interference (EMI) by adjusting the drive strength of the MAC interface
> > +      output signals. Valid values depend on the vddmac voltage setting
> > +      according to the edge rate change table in the datasheet.
> > +      For vddmac=3300mV valid values are 0, 2, 4, 7, 10, 17, 29, 53. (7 recommended)
> > +      For vddmac=2500mV valid values are 0, 3, 6, 10, 14, 23, 37, 63. (10 recommended)
> > +      For vddmac=1800mV valid values are 0, 5, 9, 16, 23, 35, 52, 76. (0 recommended)
> > +      For vddmac=1500mV valid values are 0, 6, 14, 21, 29, 42, 58, 77. (0 recommended)
>
> Indent lists by 2 more spaces and a blank line before.
>
Ok, will do.

> > +    enum: [0, 2, 3, 4, 5, 6, 7, 9, 10, 14, 16, 17, 21, 23, 29, 35, 37, 42, 52, 53, 58, 63, 76, 77]
> > +    default: 0
> > +
> > +  vsc8531,led-0-mode:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: LED[0] behavior mode. See include/dt-bindings/net/mscc-phy-vsc8531.h
> > +      for available modes.
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 1
> > +
> > +  vsc8531,led-1-mode:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: LED[1] behavior mode. See include/dt-bindings/net/mscc-phy-vsc8531.h
> > +      for available modes.
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 2
> > +
> > +  vsc8531,led-2-mode:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: LED[2] behavior mode. See include/dt-bindings/net/mscc-phy-vsc8531.h
> > +      for available modes.
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 0
> > +
> > +  vsc8531,led-3-mode:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: LED[3] behavior mode. See include/dt-bindings/net/mscc-phy-vsc8531.h
> > +      for available modes.
> > +    minimum: 0
> > +    maximum: 15
> > +    default: 8
> > +
> > +  load-save-gpios:
> > +    description: GPIO phandle used for the load/save operation of the PTP hardware
> > +      clock (PHC).
> > +    maxItems: 1
> > +
> > +dependencies:
> > +  vsc8531,edge-slowdown: [ vsc8531,vddmac ]
>
> You either need quotes on 'vsc8531,vddmac' or use this style:
>
If I use the quotes I get the below error, so I choose the below option instead.

mscc-phy-vsc8531.yaml:104:28: [error] string value is redundantly
quoted with any quotes (quoted-strings)

> vsc8531,edge-slowdown:
>   - vsc8531,vddmac
>

Cheers,
Prabhakar