linux-kernel - Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDSFVM1TXN8C.3JNX2M8XX04IF@cknow-tech.com>
Date: Sun, 26 Oct 2025 18:44:42 +0100
From: "Diederik de Haas" <diederik@...ow-tech.com>
To: "Diederik de Haas" <diederik@...ow-tech.com>, "Rob Herring"
 <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor
 Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>
Cc: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 "Dragan Simic" <dsimic@...jaro.org>, "Johan Jonker" <jbx6244@...il.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting
 for Pine64 rk3566 devices

On Sun Oct 26, 2025 at 4:37 PM CET, Diederik de Haas wrote:
> The regulator node properties in Pine64 rk3566 devices were formatted
> rather inconsistently. To name a few:
> - 'name' was sometimes put at the top of the list, while at other times
>   it was (mostly) sorted in alphabetical order
> - 'always-on' and 'boot-on' were sometimes at the top of the list,
>   sometimes not
> - 'state-mem' nodes sometimes had a preceding blank line, as they
>   should, but sometimes not
> - other properties seem to have been added to the end of the list, not
>   in their alphabetical/natural order
>
> So harmonize the formatting by making all properties sorted
> alphabetically/naturally. And harmonize the formatting of the
> 'state-mem' nodes so they all have a preceding blank line. While at it,
> also fix 2 incorrectly indented nodes.
>
> No functional changes.

I just found some additional ones.
If these changes are considered OK (in principle), then I'll send a v2
at some point.

Cheers,
  Diederik

> Signed-off-by: Diederik de Haas <diederik@...ow-tech.com>
> ---
>  .../boot/dts/rockchip/rk3566-pinenote.dtsi    | 52 +++++++++----------
>  .../boot/dts/rockchip/rk3566-pinetab2.dtsi    | 29 ++++++++---
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 51 +++++++++++-------
>  .../boot/dts/rockchip/rk3566-quartz64-b.dts   | 52 ++++++++++---------
>  .../dts/rockchip/rk3566-soquartz-blade.dts    |  6 +--
>  .../boot/dts/rockchip/rk3566-soquartz-cm4.dts |  6 +--
>  .../dts/rockchip/rk3566-soquartz-model-a.dts  | 10 ++--
>  .../boot/dts/rockchip/rk3566-soquartz.dtsi    | 43 ++++++++++-----
>  8 files changed, 148 insertions(+), 101 deletions(-)