linux-kernel - Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d190d649-acd5-4202-4a7a-94b9ada67b17@manjaro.org>
Date: Mon, 27 Oct 2025 12:38:42 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Diederik de Haas" <diederik@...ow-tech.com>
Cc: "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, "Johan Jonker" <jbx6244@...il.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 
 devices

Hello Diederik,

On Sunday, October 26, 2025 18:44 CET, "Diederik de Haas" <diederik@...ow-tech.com> wrote:
> On Sun Oct 26, 2025 at 4:37 PM CET, Diederik de Haas wrote:
> > The regulator node properties in Pine64 rk3566 devices were formatted
> > rather inconsistently. To name a few:
> > - 'name' was sometimes put at the top of the list, while at other times
> >   it was (mostly) sorted in alphabetical order
> > - 'always-on' and 'boot-on' were sometimes at the top of the list,
> >   sometimes not
> > - 'state-mem' nodes sometimes had a preceding blank line, as they
> >   should, but sometimes not
> > - other properties seem to have been added to the end of the list, not
> >   in their alphabetical/natural order
> >
> > So harmonize the formatting by making all properties sorted
> > alphabetically/naturally. And harmonize the formatting of the
> > 'state-mem' nodes so they all have a preceding blank line. While at it,
> > also fix 2 incorrectly indented nodes.
> >
> > No functional changes.
> 
> I just found some additional ones.
> If these changes are considered OK (in principle), then I'll send a v2
> at some point.

Thanks for this patch!  FWIW, I think that SoC-wide DT cleanups
and unifications such as this are nice and safe to do, so my vote
goes towards the v2. :)

> > Signed-off-by: Diederik de Haas <diederik@...ow-tech.com>
> > ---
> >  .../boot/dts/rockchip/rk3566-pinenote.dtsi    | 52 +++++++++----------
> >  .../boot/dts/rockchip/rk3566-pinetab2.dtsi    | 29 ++++++++---
> >  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 51 +++++++++++-------
> >  .../boot/dts/rockchip/rk3566-quartz64-b.dts   | 52 ++++++++++---------
> >  .../dts/rockchip/rk3566-soquartz-blade.dts    |  6 +--
> >  .../boot/dts/rockchip/rk3566-soquartz-cm4.dts |  6 +--
> >  .../dts/rockchip/rk3566-soquartz-model-a.dts  | 10 ++--
> >  .../boot/dts/rockchip/rk3566-soquartz.dtsi    | 43 ++++++++++-----
> >  8 files changed, 148 insertions(+), 101 deletions(-)