linux-kernel - Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5054965.31r3eYUQgx@phil>
Date: Mon, 27 Oct 2025 17:46:54 +0100
From: Heiko Stuebner <heiko@...ech.de>
To: Diederik de Haas <diederik@...ow-tech.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Diederik de Haas <diederik@...ow-tech.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Dragan Simic <dsimic@...jaro.org>, Johan Jonker <jbx6244@...il.com>
Subject:
 Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64
 rk3566 devices

Am Sonntag, 26. Oktober 2025, 18:44:42 Mitteleuropäische Normalzeit schrieb Diederik de Haas:
> On Sun Oct 26, 2025 at 4:37 PM CET, Diederik de Haas wrote:
> > The regulator node properties in Pine64 rk3566 devices were formatted
> > rather inconsistently. To name a few:
> > - 'name' was sometimes put at the top of the list, while at other times
> >   it was (mostly) sorted in alphabetical order
> > - 'always-on' and 'boot-on' were sometimes at the top of the list,
> >   sometimes not
> > - 'state-mem' nodes sometimes had a preceding blank line, as they
> >   should, but sometimes not
> > - other properties seem to have been added to the end of the list, not
> >   in their alphabetical/natural order
> >
> > So harmonize the formatting by making all properties sorted
> > alphabetically/naturally. And harmonize the formatting of the
> > 'state-mem' nodes so they all have a preceding blank line. While at it,
> > also fix 2 incorrectly indented nodes.
> >
> > No functional changes.
> 
> I just found some additional ones.
> If these changes are considered OK (in principle), then I'll send a v2
> at some point.

Originally, I always liked regulator-name to be on top, identifying
the regulator, similar to how compatible works.

But I do have to concede that this is just another "special-case" of
style-preference, that makes it harder to explain things to people
and in the end we should just follow the documented sorting, without
tribal knowledge :-) .


The other issue with moving stuff around is, that it makes it harder
to follow git history, because git blame then reports the sort-commit.


I guess it is ok for individual files, someone does take care of,
like Diederik for the Pinetab, but please don't start resorting all the
existing devicetrees :-) .


Heiko