linux-kernel - Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DDTD9DGY2LEK.1XF49J28I22SZ@cknow-tech.com>
Date: Mon, 27 Oct 2025 20:54:17 +0100
From: "Diederik de Haas" <diederik@...ow-tech.com>
To: "Heiko Stuebner" <heiko@...ech.de>, "Diederik de Haas"
 <diederik@...ow-tech.com>, "Rob Herring" <robh@...nel.org>, "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>
Cc: <devicetree@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 "Dragan Simic" <dsimic@...jaro.org>, "Johan Jonker" <jbx6244@...il.com>,
 "Jonas Karlman" <jonas@...boo.se>
Subject: Re: [PATCH] arm64: dts: rockchip: Harmonize regulator formatting
 for Pine64 rk3566 devices

Hi Heiko (and Dragan and Jonas),

On Mon Oct 27, 2025 at 5:46 PM CET, Heiko Stuebner wrote:
> Am Sonntag, 26. Oktober 2025, 18:44:42 Mitteleuropäische Normalzeit schrieb Diederik de Haas:
>> On Sun Oct 26, 2025 at 4:37 PM CET, Diederik de Haas wrote:
>> > The regulator node properties in Pine64 rk3566 devices were formatted
>> > rather inconsistently. To name a few:
>> >
>> > So harmonize the formatting by making all properties sorted
>> > alphabetically/naturally. And harmonize the formatting of the
>> > 'state-mem' nodes so they all have a preceding blank line. While at it,
>> > also fix 2 incorrectly indented nodes.
>
> Originally, I always liked regulator-name to be on top, identifying
> the regulator, similar to how compatible works.

That makes a lot of sense to me and I had actually thought about doing
that. But I didn't have a justification for it, while referring to the
DTS style guide is a justification. My annoyance was with the
inconsistency, so consistently putting 'name' on top would be fine too.

> The other issue with moving stuff around is, that it makes it harder
> to follow git history, because git blame then reports the sort-commit.

Then it's not worth it ...

> I guess it is ok for individual files, someone does take care of,
> like Diederik for the Pinetab, but please don't start resorting all the
> existing devicetrees :-) .

... and I'll file it under PEBKAC.

Cheers,
  Diederik