linux-kernel - Re: [PATCH v2 2/5] drm/sti: hdmi: add bridge before attaching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251027152342.GC1160161@gnbcxd0016.gnb.st.com>
Date: Mon, 27 Oct 2025 16:23:42 +0100
From: Alain Volmat <alain.volmat@...s.st.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
CC: Raphael Gallais-Pou <rgallaispou@...il.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman
	<jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Hui Pu
	<Hui.Pu@...ealthcare.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/5] drm/sti: hdmi: add bridge before attaching

Hi Luca,

On Tue, Oct 21, 2025 at 11:00:45PM +0200, Luca Ceresoli wrote:
> DRM bridges should be always added to the global bridge list before being
> attached.
> 
> Link: https://lore.kernel.org/all/20250709-sophisticated-loon-of-rain-6ccdd8@houat/
> Acked-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---
>  drivers/gpu/drm/sti/sti_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
> index 4e7c3d78b2b971f8083deae96f3967b44a6499cb..f8222e60b1e01afb6d93f816915f17056c060f22 100644
> --- a/drivers/gpu/drm/sti/sti_hdmi.c
> +++ b/drivers/gpu/drm/sti/sti_hdmi.c
> @@ -1459,6 +1459,7 @@ static int sti_hdmi_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, hdmi);
>  
> +	drm_bridge_add(&hdmi->bridge);
>  	return component_add(&pdev->dev, &sti_hdmi_ops);
>  
>   release_adapter:
> @@ -1475,6 +1476,7 @@ static void sti_hdmi_remove(struct platform_device *pdev)
>  	if (hdmi->audio_pdev)
>  		platform_device_unregister(hdmi->audio_pdev);
>  	component_del(&pdev->dev, &sti_hdmi_ops);
> +	drm_bridge_remove(&hdmi->bridge);
>  }
>  
>  struct platform_driver sti_hdmi_driver = {
> 
> -- 
> 2.51.0
> 

Acked-by: Alain Volmat <alain.volmat@...s.st.com>

Regards,
Alain