linux-kernel - Re: [PATCH v2 1/5] drm/sti: hda: add bridge before attaching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027152303.GB1160161@gnbcxd0016.gnb.st.com>
Date: Mon, 27 Oct 2025 16:23:03 +0100
From: Alain Volmat <alain.volmat@...s.st.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
CC: Raphael Gallais-Pou <rgallaispou@...il.com>,
        Maarten Lankhorst
	<maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman
	<jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Hui Pu
	<Hui.Pu@...ealthcare.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/5] drm/sti: hda: add bridge before attaching

Hi Luca,

On Tue, Oct 21, 2025 at 11:00:44PM +0200, Luca Ceresoli wrote:
> DRM bridges should be always added to the global bridge list before being
> attached.
> 
> Link: https://lore.kernel.org/all/20250709-sophisticated-loon-of-rain-6ccdd8@houat/
> Acked-by: Raphael Gallais-Pou <rgallaispou@...il.com>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---
>  drivers/gpu/drm/sti/sti_hda.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c
> index 2c015f563de96ae58959801493ead870c49f70e5..b7397827889c94d6f8e8c2a48b09f06e29ceeaf7 100644
> --- a/drivers/gpu/drm/sti/sti_hda.c
> +++ b/drivers/gpu/drm/sti/sti_hda.c
> @@ -779,6 +779,8 @@ static int sti_hda_probe(struct platform_device *pdev)
>  		return PTR_ERR(hda->clk_hddac);
>  	}
>  
> +	drm_bridge_add(&hda->bridge);
> +
>  	platform_set_drvdata(pdev, hda);
>  
>  	return component_add(&pdev->dev, &sti_hda_ops);
> @@ -786,7 +788,10 @@ static int sti_hda_probe(struct platform_device *pdev)
>  
>  static void sti_hda_remove(struct platform_device *pdev)
>  {
> +	struct sti_hda *hda = platform_get_drvdata(pdev);
> +
>  	component_del(&pdev->dev, &sti_hda_ops);
> +	drm_bridge_remove(&hda->bridge);
>  }
>  
>  static const struct of_device_id hda_of_match[] = {
> 
> -- 
> 2.51.0
> 

Acked-by: Alain Volmat <alain.volmat@...s.st.com>

Regards,
Alain