linux-kernel - Re: [PATCH v6 3/8] dt-bindings: leds: Binding for RTL8231 scan matrix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d1bf3eacd59a3cea1330a16bf7a9a328cd6d806.camel@svanheule.net>
Date: Mon, 27 Oct 2025 18:12:43 +0100
From: Sander Vanheule <sander@...nheule.net>
To: Rob Herring <robh@...nel.org>
Cc: Michael Walle <mwalle@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>,  Bartosz Golaszewski	 <brgl@...ev.pl>,
 linux-gpio@...r.kernel.org, Lee Jones <lee@...nel.org>, Pavel Machek
 <pavel@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley	
 <conor+dt@...nel.org>, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 3/8] dt-bindings: leds: Binding for RTL8231 scan
 matrix

Hi Rob,

On Sun, 2025-10-26 at 16:59 -0500, Rob Herring wrote:
> On Tue, Oct 21, 2025 at 04:23:58PM +0200, Sander Vanheule wrote:
> > +  realtek,led-scan-mode:
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    description: |
> 
> You don't need '|' if there is no formatting to preserve.

Will drop it.

> > +      Specify the scanning mode the chip should run in. See general
> > description
> > +      for how the scanning matrices are wired up.
> > +    enum: [single-color, bi-color]
> 
> Wouldn't 'single' and 'bi' be sufficient?

I used these values to align with the datasheet:

   En_bicolor
   1'b0: Uses single-color LED when in Scan LED mode
   1'b1: Uses bi-color LED when in Scan LED mode

If you would like a single word, I would prefer [single, dual] and mention the
single-color/bi-color mapping in the description.

> 
> > +
> > +patternProperties:
> > +  "^led@":
> 
> You need to define the unit-address format:
> 
> "^led@([1-2]?[0-9]|3[0-1]),[0-2]$"

Hadn't considered that yet. I'll update this too.


Best,
Sander