linux-kernel - Re: [PATCH v2] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7dc31259-c172-de0e-554c-2563014b9c2c@manjaro.org>
Date: Mon, 27 Oct 2025 19:19:36 +0100
From: "Dragan Simic" <dsimic@...jaro.org>
To: "Jonas Karlman" <jonas@...boo.se>
Cc: "Diederik de Haas" <diederik@...ow-tech.com>, "Rob Herring" <robh@...nel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, "Johan Jonker" <jbx6244@...il.com>
Subject: Re: [PATCH v2] arm64: dts: rockchip: Harmonize regulator formatting for Pine64 rk3566 
 devices

Hello Jonas and Heiko,

On Monday, October 27, 2025 19:06 CET, Jonas Karlman <jonas@...boo.se> wrote:
> On 10/27/2025 4:39 PM, Diederik de Haas wrote:
> > The regulator node properties in Pine64 rk3566 devices were formatted
> > rather inconsistently. To name a few:
> > - 'name' was sometimes put at the top of the list, while at other times
> >   it was (mostly) sorted in alphabetical order
> 
> Personally I prefer to list the regulator-name as the first property, I
> think it makes it visually easier/quicker to identify a regulator with
> the name prop at top.
> 
> I typically try to use the following prop ordering for regulators on
> board DTs I submit (and review):
> 
> - regulator-name as the first prop (to quickly identify the regulator)
> - regulator-min-* before regulator-max-* (natural order)
> - regulator-* in alphabetical/natural order
> 
> Maybe this preference just comes from a long history of always putting
> id/primary key/unique identifiers at top or beginning of data tables,
> classes, structs etc ;-)

Oh, I actually agree with your and Heiko's preferences when
it comes to the ordering, regardless of that being personal
preference, tribal knowledge or just common sense. :)

However, that's quite conflicting with the current official
rules for writing DT files, which don't recognize such exceptions
at all.  Perhaps we should attempt to incorporate such preferences
into the official rules, because such non-standard ordering does
make DTs more readable?  Following the rules is good, unless it
makes the end results worse, IMHO.