linux-kernel - Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251027232847.GA1488235@bhelgaas>
Date: Mon, 27 Oct 2025 18:28:47 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: thippeswamy.havalige@....com, Ravi Kumar Bandi <ravib@...zon.com>,
	lpieralisi@...nel.org, bhelgaas@...gle.com,
	linux-pci@...r.kernel.org, kwilczynski@...nel.org, robh@...nel.org,
	michal.simek@....com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Stefan Roese <stefan.roese@...lbox.org>,
	"Musham, Sai Krishna" <sai.krishna.musham@....com>,
	Sean Anderson <sean.anderson@...ux.dev>,
	"Yeleswarapu, Nagaradhesh" <nagaradhesh.yeleswarapu@....com>
Subject: Re: [PATCH v2] PCI: xilinx-xdma: Enable INTx interrupts

[+cc Stefan et al]

On Sun, Oct 19, 2025 at 12:39:25PM +0530, Manivannan Sadhasivam wrote:
> On Sat, 20 Sep 2025 22:52:32 +0000, Ravi Kumar Bandi wrote:
> > The pcie-xilinx-dma-pl driver does not enable INTx interrupts
> > after initializing the port, preventing INTx interrupts from
> > PCIe endpoints from flowing through the Xilinx XDMA root port
> > bridge. This issue affects kernel 6.6.0 and later versions.
> > 
> > This patch allows INTx interrupts generated by PCIe endpoints
> > to flow through the root port. Tested the fix on a board with
> > two endpoints generating INTx interrupts. Interrupts are
> > properly detected and serviced. The /proc/interrupts output
> > shows:
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] PCI: xilinx-xdma: Enable INTx interrupts
>       commit: c098c13f4365e6750009be4d90dba36fa4a19b4e

Pretty sure we have confirmation that we don't need either this patch
or Stefan's patch, so I removed the pci/controller/xilinx-dma branch.

It was at 2002478e5034 ("PCI: xilinx-xdma: Enable INTx interrupts") in
case we need to resurrect it.

IIUC, Stefan confirmed that he didn't need this patch (Ravi's) [1],
and that after Vivado is fixed to generate the correct interrupt-map,
his patch (Stefan's) won't be needed either [2].

[1] https://lore.kernel.org/r/29bc5e92-04c9-475a-ba3d-a5ea26f1c95a@mailbox.org
[2] https://lore.kernel.org/r/9c7e43c3-24e9-4b08-a6ce-2035b50226f4@mailbox.org