linux-kernel - Re: [PATCH] crypto: qat - use strscpy_pad to simplify buffer initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aP8rHYq4I09pvhFa@smile.fi.intel.com>
Date: Mon, 27 Oct 2025 10:19:41 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Jack Xu <jack.xu@...el.com>,
	Suman Kumar Chakraborty <suman.kumar.chakraborty@...el.com>,
	Qianfeng Rong <rongqianfeng@...o.com>, qat-linux@...el.com,
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: qat - use strscpy_pad to simplify buffer
 initialization

On Fri, Oct 24, 2025 at 08:47:02PM +0200, Thorsten Blum wrote:
> On 23. Oct 2025, at 20:44, Andy Shevchenko wrote:
> > On Thu, Oct 23, 2025 at 05:35:00PM +0200, Thorsten Blum wrote:
> >> On 22. Oct 2025, at 20:17, Andy Shevchenko wrote:
> >>> On Wed, Oct 22, 2025 at 02:36:19PM +0200, Thorsten Blum wrote:

...

> >> How about this?
> > 
> > LGTM, and that's what I had in mind, ...
> 
> I was about to submit v2, but checkpatch warns me about simple_strtoull:
> 
>   WARNING: simple_strtoull is obsolete, use kstrtoull instead
> 
> Any recommendations?

Yes, fix checkpatch as per commit 885e68e8b7b1 ("kernel.h: update comment about
simple_strto<foo>() functions") or ignore this false positive.

-- 
With Best Regards,
Andy Shevchenko