linux-kernel - Re: [PATCH v2] crypto: qat - use simple_strtoull to improve qat_uclo_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aP8xocba5k3fAyaB@gcabiddu-mobl.ger.corp.intel.com>
Date: Mon, 27 Oct 2025 08:47:29 +0000
From: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To: Thorsten Blum <thorsten.blum@...ux.dev>
CC: Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Jack Xu <jack.xu@...el.com>, Suman Kumar Chakraborty
	<suman.kumar.chakraborty@...el.com>, Qianfeng Rong <rongqianfeng@...o.com>,
	<qat-linux@...el.com>, <linux-crypto@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] crypto: qat - use simple_strtoull to improve
 qat_uclo_parse_num

On Sun, Oct 26, 2025 at 02:57:07AM +0100, Thorsten Blum wrote:
> Replace the manual string copying and parsing logic with a call to
> simple_strtoull() to simplify and improve qat_uclo_parse_num().
> 
> Ensure that the parsed number does not exceed UINT_MAX, and add an
> approximate upper-bound check (no more than 19 digits) to guard against
> overflow.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

Thanks,

-- 
Giovanni