lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251027-tacky-electric-wildebeest-ff8ad6@kuoka>
Date: Mon, 27 Oct 2025 09:47:05 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
Cc: Mark Brown <broonie@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>, 
	David Rhodes <david.rhodes@...rus.com>, Richard Fitzgerald <rf@...nsource.cirrus.com>, 
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, 
	patches@...nsource.cirrus.com, devicetree@...r.kernel.org
Subject: Re: [PATCH v6 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: Add
 SPI bus support

On Thu, Oct 23, 2025 at 10:03:19AM +0100, Vitaly Rodionov wrote:
> The CS530x device family supports multiple control interfaces.
> At present, only the I2C interface is implemented. Adding support
> for the SPI control interface, operating at up to 24 MHz.

subject - too many sound prefixes. It is ASoC and dt-bindings. ASoC
defines sound.

Please use subject prefixes matching the subsystem. You can get them for
example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Signed-off-by: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
> ---

<form letter>
This is an automated instruction, just in case, because many review
tags are being ignored. If you know the process, just skip it entirely
(please do not feel offended by me posting it here - no bad intentions
intended, no patronizing, I just want to avoid wasted efforts). If you
do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here ('b4 trailers -u ...').
However, there's no need to repost patches *only* to add the tags. The
upstream maintainer will do that for tags received on the version they
apply.

https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
</form letter>

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ