linux-kernel - [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251027100529.1806944-1-andriy.shevchenko@linux.intel.com>
Date: Mon, 27 Oct 2025 11:05:29 +0100
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev
Cc: Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>,
	Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	Aaron Lu <ziqianlu@...edance.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building

Clang, in particular, is not happy about dead code:

kernel/sched/fair.c:5233:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
 5233 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
      |                   ^~~~~~~~~~~~~~~~
1 error generated.

kernel/sched/fair.c:6736:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
 6736 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
      |                   ^~~~~~~~~~~~~~~~
1 error generated.

Remove a leftover from the previous cleanup.

Fixes: fe8d238e646e ("sched/fair: Propagate load for throttled cfs_rq")
Fixes: eb962f251fbb ("sched/fair: Task based throttle time accounting")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
---
 kernel/sched/fair.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 273e2871b59e..0370f11e5c25 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5230,7 +5230,6 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
 }
 
 static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
-static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
 
 static void
 requeue_delayed_entity(struct sched_entity *se);
@@ -6733,11 +6732,6 @@ static void dequeue_throttled_task(struct task_struct *p, int flags) {}
 static bool enqueue_throttled_task(struct task_struct *p) { return false; }
 static void record_throttle_clock(struct cfs_rq *cfs_rq) {}
 
-static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
-{
-	return 0;
-}
-
 static inline bool cfs_rq_pelt_clock_throttled(struct cfs_rq *cfs_rq)
 {
 	return false;
-- 
2.50.1