linux-kernel - Re: [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251027111552.GA33@bytedance>
Date: Mon, 27 Oct 2025 19:15:52 +0800
From: Aaron Lu <ziqianlu@...edance.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev, Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Vincent Guittot <vincent.guittot@...aro.org>,
	Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] sched/fair: Remove dead code which might prevent
 from building

On Mon, Oct 27, 2025 at 11:05:29AM +0100, Andy Shevchenko wrote:
> Clang, in particular, is not happy about dead code:
> 
> kernel/sched/fair.c:5233:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
>  5233 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
>       |                   ^~~~~~~~~~~~~~~~
> 1 error generated.
> 
> kernel/sched/fair.c:6736:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
>  6736 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
>       |                   ^~~~~~~~~~~~~~~~
> 1 error generated.
> 
> Remove a leftover from the previous cleanup.
> 
> Fixes: fe8d238e646e ("sched/fair: Propagate load for throttled cfs_rq")
> Fixes: eb962f251fbb ("sched/fair: Task based throttle time accounting")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Aaron Lu <ziqianlu@...edance.com>

Thanks.