linux-kernel - Re: [PATCH v1 1/5] dt-bindings: thermal: mediatek: make interrupt only required for current SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a8bf2e9-5033-4588-923c-53ad23c12924@collabora.com>
Date: Mon, 27 Oct 2025 11:43:45 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Frank Wunderlich <linux@...web.de>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>,
 Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>, Mason Chang <mason-cw.chang@...iatek.com>
Cc: Frank Wunderlich <frank-w@...lic-files.de>,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Balsam CHIHI <bchihi@...libre.com>, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v1 1/5] dt-bindings: thermal: mediatek: make interrupt
 only required for current SoCs

Il 26/10/25 13:21, Frank Wunderlich ha scritto:
> From: Frank Wunderlich <frank-w@...lic-files.de>
> 
> Upcoming MT7987 does not have a IRQ we have to make interrupt-property only
> required for current supported SoCs.

Hmm. Thermal sensor IP with no interrupt? Looks really strange.

This is odd, because LVTS always has multiple interrupts, and if this doesn't
actually feature any, it really feels like the hardware is broken somehow.

MediaTek, can you please confirm whether the LVTS IP in MT7987 is really
like that, or can you please give the right interrupt number to Frank?

Thanks,
Angelo

> 
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
> ---
>   .../bindings/thermal/mediatek,lvts-thermal.yaml | 17 ++++++++++++++++-
>   1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> index 0259cd3ce9c5..7ec9c46eef22 100644
> --- a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> @@ -58,6 +58,16 @@ properties:
>   allOf:
>     - $ref: thermal-sensor.yaml#
>   
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - mediatek,mt7988-lvts-ap
> +    then:
> +      required:
> +        - interrupts
> +
>     - if:
>         properties:
>           compatible:
> @@ -75,6 +85,9 @@ allOf:
>           nvmem-cell-names:
>             maxItems: 1
>   
> +      required:
> +        - interrupts
> +
>     - if:
>         properties:
>           compatible:
> @@ -91,10 +104,12 @@ allOf:
>           nvmem-cell-names:
>             minItems: 2
>   
> +      required:
> +        - interrupts
> +
>   required:
>     - compatible
>     - reg
> -  - interrupts
>     - clocks
>     - resets
>     - nvmem-cells